Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] add support for extended_stats #120340

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Conversation

prwhelan
Copy link
Member

Building off of stats and multi-value aggregations, including the limitation:

  • all values of extended_stats will be mapped to double if mapping deduction is used

Relates #51925

Building off of `stats` and multi-value aggregations, including the
limitation:
- all values of extended_stats will be mapped to `double` if mapping
  deduction is used

Relates elastic#51925
@prwhelan prwhelan added >enhancement :ml/Transform Transform Team:ML Meta label for the ML team auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 labels Jan 17, 2025
Copy link
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Hi @prwhelan, I've created a changelog YAML for you.

@prwhelan prwhelan marked this pull request as ready for review January 17, 2025 01:46
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@daixque
Copy link
Contributor

daixque commented Jan 17, 2025

This looks std_deviation_bounds won't be extracted. Is it intentional?

@prwhelan
Copy link
Member Author

This looks std_deviation_bounds won't be extracted. Is it intentional?

It exists as its internal representation - a flattened structure rather than a nested map

We can instead convert it to a nested map

@prwhelan prwhelan removed auto-backport Automatically create backport pull requests when merged v8.18.0 labels Jan 28, 2025
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be backported to 8.18 too?

@prwhelan prwhelan added auto-backport Automatically create backport pull requests when merged v8.18.0 labels Jan 29, 2025
@prwhelan prwhelan enabled auto-merge (squash) January 29, 2025 13:24
@prwhelan prwhelan merged commit 9009606 into elastic:main Jan 29, 2025
16 checks passed
prwhelan added a commit to prwhelan/elasticsearch that referenced this pull request Jan 29, 2025
Building off of `stats` and multi-value aggregations, including the
limitation:
- all values of extended_stats will be mapped to `double` if mapping
  deduction is used

Relates elastic#51925
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

elasticsearchmachine pushed a commit that referenced this pull request Jan 29, 2025
Building off of `stats` and multi-value aggregations, including the
limitation:
- all values of extended_stats will be mapped to `double` if mapping
  deduction is used

Relates #51925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >enhancement :ml/Transform Transform Team:ML Meta label for the ML team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants