Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] IndexVersionUtiltsTests testGradleVersionsMatchVersionUtils failing #98054

Open
valeriy42 opened this issue Jul 31, 2023 · 10 comments · May be fixed by #120406
Open

[CI] IndexVersionUtiltsTests testGradleVersionsMatchVersionUtils failing #98054

valeriy42 opened this issue Jul 31, 2023 · 10 comments · May be fixed by #120406
Assignees
@thecoop
Labels
:Core/Infra/Core Core issues without another label low-risk An open issue or test failure that is a low risk to future releases Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI

Comments

@valeriy42
Copy link
Contributor

Failed 15 times in the past 5 days

Build scan:
https://gradle-enterprise.elastic.co/s/6r337pg2sxem2/tests/:test:framework:test/org.elasticsearch.test.VersionUtilsTests/testGradleVersionsMatchVersionUtils

Reproduction line:

./gradlew ':test:framework:test' --tests "org.elasticsearch.test.VersionUtilsTests.testGradleVersionsMatchVersionUtils" -Dtests.seed=3C5C8F70066805A -Dtests.locale=es-VE -Dtests.timezone=Atlantic/Madeira -Druntime.java=20

Applicable branches:
main

Reproduces locally?:
Yes

Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.test.VersionUtilsTests&tests.test=testGradleVersionsMatchVersionUtils

Failure excerpt:

java.lang.AssertionError: expected:<[7.0.0, 7.0.1, 7.1.0, 7.1.1, 7.2.0, 7.2.1, 7.3.0, 7.3.1, 7.3.2, 7.4.0, 7.4.1, 7.4.2, 7.5.0, 7.5.1, 7.5.2, 7.6.0, 7.6.1, 7.6.2, 7.7.0, 7.7.1, 7.8.0, 7.8.1, 7.9.0, 7.9.1, 7.9.2, 7.9.3, 7.10.0, 7.10.1, 7.10.2, 7.11.0, 7.11.1, 7.11.2, 7.12.0, 7.12.1, 7.13.0, 7.13.1, 7.13.2, 7.13.3, 7.13.4, 7.14.0, 7.14.1, 7.14.2, 7.15.0, 7.15.1, 7.15.2, 7.16.0, 7.16.1, 7.16.2, 7.16.3, 7.17.0, 7.17.1, 7.17.2, 7.17.3, 7.17.4, 7.17.5, 7.17.6, 7.17.7, 7.17.8, 7.17.9, 7.17.10, 7.17.11, 7.17.12, 8.0.0, 8.0.1, 8.1.0, 8.1.1, 8.1.2, 8.1.3, 8.2.0, 8.2.1, 8.2.2, 8.2.3, 8.3.0, 8.3.1, 8.3.2, 8.3.3, 8.4.0, 8.4.1, 8.4.2, 8.4.3, 8.5.0, 8.5.1, 8.5.2, 8.5.3, 8.6.0, 8.6.1, 8.6.2, 8.7.0, 8.7.1, 8.8.0, 8.8.1, 8.8.2, 8.9.0]> but was:<[7.12.0, 7.12.1, 7.13.0, 7.13.1, 7.13.2, 7.13.3, 7.13.4, 7.14.0, 7.14.1, 7.14.2, 7.15.0, 7.15.1, 7.15.2, 7.16.0, 7.16.1, 7.16.2, 7.16.3, 7.17.0, 7.17.1, 7.17.2, 7.17.3, 7.17.4, 7.17.5, 7.17.6, 7.17.7, 7.17.8, 7.17.9, 7.17.10, 7.17.11, 7.17.12, 8.0.0, 8.0.1, 8.1.0, 8.1.1, 8.1.2, 8.1.3, 8.2.0, 8.2.1, 8.2.2, 8.2.3, 8.3.0, 8.3.1, 8.3.2, 8.3.3, 8.4.0, 8.4.1, 8.4.2, 8.4.3, 8.5.0, 8.5.1, 8.5.2, 8.5.3, 8.6.0, 8.6.1, 8.6.2, 8.7.0, 8.7.1, 8.8.0, 8.8.1, 8.8.2, 8.9.0]>

  at __randomizedtesting.SeedInfo.seed([3C5C8F70066805A:D606D2F2CD76CD94]:0)
  at org.junit.Assert.fail(Assert.java:88)
  at org.junit.Assert.failNotEquals(Assert.java:834)
  at org.junit.Assert.assertEquals(Assert.java:118)
  at org.junit.Assert.assertEquals(Assert.java:144)
  at org.elasticsearch.test.VersionUtilsTests.testGradleVersionsMatchVersionUtils(VersionUtilsTests.java:312)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
  at java.lang.reflect.Method.invoke(Method.java:578)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1623)
@valeriy42 valeriy42 added :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test-failure Triaged test failures from CI labels Jul 31, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@valeriy42 valeriy42 self-assigned this Jul 31, 2023
valeriy42 added a commit to valeriy42/elasticsearch that referenced this issue Jul 31, 2023
@valeriy42
Mute VersionUtilsTests testGradleVersionsMatchVersionUtils
cb1dbc3 
Relates elastic#98054
@valeriy42 valeriy42 mentioned this issue Jul 31, 2023
Merged
valeriy42 added a commit that referenced this issue Jul 31, 2023
@valeriy42
Mute VersionUtilsTests testGradleVersionsMatchVersionUtils (#98056)
62bebfd 
Mutes failing test from #98054
@valeriy42
Copy link
Contributor Author

Muted in 62bebfd

@thecoop
Copy link
Member

thecoop commented Aug 22, 2023

This has been modified by #98685 - the wire component has stayed in VersionUtilsTests and is unmuted, the index component has moved to IndexVersionUtilsTests and needs to be updated for the changes from IndexVersion

@mark-vieira
Copy link
Contributor

Resolved by #98685.

@idegtiarenko
Copy link
Contributor

Apparently AwaitsFix is still present on the test:

elasticsearch/test/framework/src/test/java/org/elasticsearch/test/index/IndexVersionUtilsTests.java

Lines 26 to 27 in 8a1db8c

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/98054")
public void testGradleVersionsMatchVersionUtils() {

Once it is removed then the test is failing again so I am going to re-open this issue.

@idegtiarenko idegtiarenko reopened this Nov 9, 2023
@mark-vieira mark-vieira added the low-risk An open issue or test failure that is a low risk to future releases label Nov 9, 2023
@mark-vieira
Copy link
Contributor

Categorizing this as low risk since it doesn't affect production code.

@mark-vieira
Copy link
Contributor

This was resolved by #98685.

@javanna
Copy link
Member

javanna commented Dec 18, 2024 •
edited
Loading

The test (now in IndexVersionUtiltsTests) is still muted in main. The @AwaitsFix links to this issue. Re-opening.

@javanna javanna reopened this Dec 18, 2024
@valeriy42 valeriy42 removed their assignment Dec 19, 2024
@mark-vieira mark-vieira changed the title [CI] VersionUtilsTests testGradleVersionsMatchVersionUtils failing [CI] IndexVersionUtiltsTests testGradleVersionsMatchVersionUtils failing Dec 19, 2024
@mark-vieira mark-vieira added :Core/Infra/Core Core issues without another label and removed :Delivery/Build Build or test infrastructure labels Dec 19, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Dec 19, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine removed the Team:Delivery Meta label for Delivery team label Dec 19, 2024
@mark-vieira
Copy link
Contributor

The IndexVersionUtilsTests variant seems to be failing because we are comparing semantic version strings to index versions. I'm assigning this to core/infra to look into.

@thecoop thecoop linked a pull request Jan 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thecoop thecoop

Labels
:Core/Infra/Core Core issues without another label low-risk An open issue or test failure that is a low risk to future releases Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the index version compatible test to only check the minimum thecoop/elasticsearch
6 participants
@javanna @valeriy42 @idegtiarenko @thecoop @mark-vieira @elasticsearchmachine