diff --git a/rmw_iceoryx2_cxx/CMakeLists.txt b/rmw_iceoryx2_cxx/CMakeLists.txt index e0a7730..d20bb81 100644 --- a/rmw_iceoryx2_cxx/CMakeLists.txt +++ b/rmw_iceoryx2_cxx/CMakeLists.txt @@ -56,16 +56,17 @@ endforeach() # ---------------------------------------------------------------------------- add_library(${PROJECT_NAME} SHARED - src/iox2/context_impl.cpp - src/iox2/guard_condition_impl.cpp - src/iox2/iceoryx2.cpp - src/iox2/names.cpp - src/iox2/node_impl.cpp - src/iox2/publisher_impl.cpp - src/iox2/subscriber_impl.cpp - src/iox2/waitset_impl.cpp - src/message/introspect.cpp - src/message/serialize.cpp + src/impl/common/names.cpp + src/impl/message/introspection.cpp + src/impl/message/serialization.cpp + src/impl/middleware/iceoryx2.cpp + src/impl/runtime/context.cpp + src/impl/runtime/guard_condition.cpp + src/impl/runtime/node.cpp + src/impl/runtime/publisher.cpp + src/impl/runtime/subscriber.cpp + src/impl/runtime/waitset.cpp + src/rmw/client.cpp src/rmw/event.cpp src/rmw/feature.cpp @@ -149,14 +150,14 @@ if(BUILD_TESTING) ament_add_gtest(test_rmw_iceoryx2_cxx test/testing/base.cpp - test/test_iox2_context_impl.cpp - test/test_iox2_guard_condition_impl.cpp - test/test_iox2_message_introspection.cpp - test/test_iox2_node_impl.cpp - test/test_iox2_publisher_impl.cpp - test/test_iox2_sample_registry.cpp - test/test_iox2_subscriber_impl.cpp - test/test_iox2_waitset_impl.cpp + test/test_impl_context.cpp + test/test_impl_guard_condition.cpp + test/test_impl_message_introspection.cpp + test/test_impl_node.cpp + test/test_impl_publisher.cpp + test/test_impl_sample_registry.cpp + test/test_impl_subscriber.cpp + test/test_impl_waitset.cpp test/test_rmw_allocator.cpp test/test_rmw_gid.cpp test/test_rmw_graph.cpp diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/allocator.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/allocator.hpp similarity index 94% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/allocator.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/allocator.hpp index 327c515..b937078 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/allocator.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/allocator.hpp @@ -7,14 +7,14 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_ALLOCATOR_HELPERS_HPP_ -#define RMW_IOX2_ALLOCATOR_HELPERS_HPP_ +#ifndef RMW_IOX2_COMMON_ALLOCATOR_HPP_ +#define RMW_IOX2_COMMON_ALLOCATOR_HPP_ #include "iox/expected.hpp" #include "rmw/allocators.h" #include "rmw/visibility_control.h" -#include "rmw_iceoryx2_cxx/error.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" #include diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/create.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/create.hpp similarity index 94% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/create.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/create.hpp index ad48a5f..f0cbaf9 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/create.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/create.hpp @@ -7,16 +7,15 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_CREATE_HPP_ -#define RMW_IOX2_CREATE_HPP_ +#ifndef RMW_IOX2_COMMON_CREATE_HPP_ +#define RMW_IOX2_COMMON_CREATE_HPP_ #include "iox/expected.hpp" #include "iox/optional.hpp" -#include "iox2/service_builder_publish_subscribe_error.hpp" #include "rmw/visibility_control.h" -#include "rmw_iceoryx2_cxx/creation_lock.hpp" -#include "rmw_iceoryx2_cxx/error.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/creation_lock.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" namespace rmw::iox2 { diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/creation_lock.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/creation_lock.hpp similarity index 95% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/creation_lock.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/creation_lock.hpp index 4d1a560..0951634 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/creation_lock.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/creation_lock.hpp @@ -7,8 +7,8 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_CREATION_LOCK_HPP_ -#define RMW_IOX2_CREATION_LOCK_HPP_ +#ifndef RMW_IOX2_COMMON_CREATION_LOCK_HPP_ +#define RMW_IOX2_COMMON_CREATION_LOCK_HPP_ #include "iox/expected.hpp" diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/defaults.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/defaults.hpp similarity index 89% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/defaults.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/defaults.hpp index b0bdd49..0f9098f 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/defaults.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/defaults.hpp @@ -9,8 +9,8 @@ #include "rcutils/types/string_array.h" -#ifndef RMW_IOX2_DEFAULTS_HPP_ -#define RMW_IOX2_DEFAULTS_HPP_ +#ifndef RMW_IOX2_COMMON_DEFAULTS_HPP_ +#define RMW_IOX2_COMMON_DEFAULTS_HPP_ constexpr rcutils_string_array_t RCUTILS_STRING_ARRAY_ZERO = { 0, // size diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/ensure.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/ensure.hpp similarity index 98% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/ensure.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/ensure.hpp index b6dd47d..890e60f 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/ensure.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/ensure.hpp @@ -7,12 +7,12 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_ENSURE_HPP_ -#define RMW_IOX2_ENSURE_HPP_ +#ifndef RMW_IOX2_COMMON_ENSURE_HPP_ +#define RMW_IOX2_COMMON_ENSURE_HPP_ -#include "rmw_iceoryx2_cxx/defaults.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/message/typesupport.hpp" +#include "rmw_iceoryx2_cxx/impl/common/defaults.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/message/typesupport.hpp" #define RMW_IOX2_ENSURE_VALID_ALLOCATOR(allocator, return_value) RCUTILS_CHECK_ALLOCATOR(allocator, return return_value) diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/error.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/error.hpp similarity index 96% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/error.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/error.hpp index 2ecdaea..9dfd619 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/error.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/error.hpp @@ -7,8 +7,8 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_ERROR_HPP_ -#define RMW_IOX2_ERROR_HPP_ +#ifndef RMW_IOX2_COMMON_ERROR_HPP_ +#define RMW_IOX2_COMMON_ERROR_HPP_ #include diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/error_message.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/error_message.hpp similarity index 97% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/error_message.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/error_message.hpp index a5159c6..33403f0 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/error_message.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/error_message.hpp @@ -7,8 +7,8 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_ERROR_HANDLING_HPP_ -#define RMW_IOX2_ERROR_HANDLING_HPP_ +#ifndef RMW_IOX2_COMMON_ERROR_MESSAGE_HPP_ +#define RMW_IOX2_COMMON_ERROR_MESSAGE_HPP_ #include "rmw/allocators.h" #include "rmw/error_handling.h" diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/log.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/log.hpp similarity index 92% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/log.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/log.hpp index 3924067..841a098 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/log.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/log.hpp @@ -7,8 +7,8 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_LOG_HPP_ -#define RMW_IOX2_LOG_HPP_ +#ifndef RMW_IOX2_COMMON_LOG_HPP_ +#define RMW_IOX2_COMMON_LOG_HPP_ #include "rcutils/logging_macros.h" diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/names.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/names.hpp similarity index 100% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/names.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/common/names.hpp diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/message/introspect.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/message/introspection.hpp similarity index 100% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/message/introspect.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/message/introspection.hpp diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/message/serialize.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/message/serialization.hpp similarity index 100% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/message/serialize.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/message/serialization.hpp diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/message/typesupport.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/message/typesupport.hpp similarity index 89% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/message/typesupport.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/message/typesupport.hpp index 8376b58..147a900 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/message/typesupport.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/message/typesupport.hpp @@ -7,8 +7,8 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_TYPESUPPORT_HPP_ -#define RMW_IOX2_TYPESUPPORT_HPP_ +#ifndef RMW_IOX2_MESSAGE_TYPESUPPORT_HPP_ +#define RMW_IOX2_MESSAGE_TYPESUPPORT_HPP_ #include "rosidl_typesupport_fastrtps_c/identifier.h" #include "rosidl_typesupport_fastrtps_cpp/identifier.hpp" diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/iceoryx2.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp similarity index 94% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/iceoryx2.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp index 4ccd6c5..607e81a 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/iceoryx2.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp @@ -7,8 +7,8 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_HANDLE_HPP_ -#define RMW_IOX2_HANDLE_HPP_ +#ifndef RMW_IOX2_MIDDLEWARE_ICEORYX2_HPP_ +#define RMW_IOX2_MIDDLEWARE_ICEORYX2_HPP_ #include "iox2/listener.hpp" #include "iox2/node.hpp" @@ -23,8 +23,8 @@ #include "iox2/subscriber.hpp" #include "iox2/waitset.hpp" #include "rmw/visibility_control.h" -#include "rmw_iceoryx2_cxx/creation_lock.hpp" -#include "rmw_iceoryx2_cxx/error.hpp" +#include "rmw_iceoryx2_cxx/impl/common/creation_lock.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error.hpp" #include @@ -34,7 +34,7 @@ namespace rmw::iox2 class Iceoryx2; template <> -struct Error +struct Error<::rmw::iox2::Iceoryx2> { using Type = HandleError; }; @@ -55,6 +55,10 @@ struct Error /// class RMW_PUBLIC Iceoryx2 { + template + using Error = ::rmw::iox2::Error; + using CreationLock = ::rmw::iox2::CreationLock; + public: // In iceoryx2, a node is an instance of iceoryx2 with its own lifetime management. using InstanceName = ::iox2::NodeName; diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/context_impl.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/context.hpp similarity index 89% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/context_impl.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/context.hpp index 6f28406..de47ed8 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/context_impl.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/context.hpp @@ -7,14 +7,14 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_CONTEXT_IMPL_HPP_ -#define RMW_IOX2_CONTEXT_IMPL_HPP_ +#ifndef RMW_IOX2_RUNTIME_CONTEXT_HPP_ +#define RMW_IOX2_RUNTIME_CONTEXT_HPP_ #include "iox/optional.hpp" #include "rmw/visibility_control.h" -#include "rmw_iceoryx2_cxx/creation_lock.hpp" -#include "rmw_iceoryx2_cxx/error.hpp" -#include "rmw_iceoryx2_cxx/iox2/iceoryx2.hpp" +#include "rmw_iceoryx2_cxx/impl/common/creation_lock.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error.hpp" +#include "rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp" #include @@ -81,7 +81,7 @@ namespace rmw::iox2 { // Used throughout implementation to indicate it is C++ -using ContextImpl = rmw_context_impl_s; +using Context = rmw_context_impl_s; } // namespace rmw::iox2 diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/guard_condition_impl.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/guard_condition.hpp similarity index 76% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/guard_condition_impl.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/guard_condition.hpp index dbbc6ac..f2d90c7 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/guard_condition_impl.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/guard_condition.hpp @@ -7,25 +7,25 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_GUARD_CONDITION_IMPL_HPP_ -#define RMW_IOX2_GUARD_CONDITION_IMPL_HPP_ +#ifndef RMW_IOX2_RUNTIME_GUARD_CONDITION_HPP_ +#define RMW_IOX2_RUNTIME_GUARD_CONDITION_HPP_ #include "iox/optional.hpp" #include "iox2/unique_port_id.hpp" #include "rmw/visibility_control.h" -#include "rmw_iceoryx2_cxx/creation_lock.hpp" -#include "rmw_iceoryx2_cxx/error.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/iceoryx2.hpp" +#include "rmw_iceoryx2_cxx/impl/common/creation_lock.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error.hpp" +#include "rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" namespace rmw::iox2 { -class NodeImpl; -class GuardConditionImpl; +class Node; +class GuardCondition; template <> -struct Error +struct Error { using Type = GuardConditionError; }; @@ -35,21 +35,21 @@ struct Error /// wake up a waiting thread. It is used in ROS 2 to signal events between /// different parts of the system. This implementation uses an iceoryx2 /// notifier to implement the guard condition functionality. -class RMW_PUBLIC GuardConditionImpl +class RMW_PUBLIC GuardCondition { using RawIdType = ::iox2::RawIdType; using IdType = ::iox2::UniquePublisherId; - using Notifier = Iceoryx2::Local::Notifier; + using IceoryxNotifier = Iceoryx2::Local::Notifier; public: - using ErrorType = Error::Type; + using ErrorType = Error::Type; public: /// @brief Creates a new guard condition /// @param[in] lock Creation lock to restrict construction to creation functions /// @param[out] error Optional error that is set if construction fails /// @param[in] context The context to associate the guard condition with - GuardConditionImpl(CreationLock, iox::optional& error, ContextImpl& context); + GuardCondition(CreationLock, iox::optional& error, Context& context); /// @brief Get the unique id of the guard condition /// @return The unique id or empty optional if failing to retrieve it from iceoryx2 @@ -72,7 +72,7 @@ class RMW_PUBLIC GuardConditionImpl const std::string m_service_name; iox::optional m_iox2_unique_id; - iox::optional m_iox2_notifier; + iox::optional m_iox2_notifier; }; } // namespace rmw::iox2 diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/node_impl.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/node.hpp similarity index 72% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/node_impl.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/node.hpp index 184984a..71fb0a1 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/node_impl.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/node.hpp @@ -7,24 +7,24 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_NODE_IMPL_HPP_ -#define RMW_IOX2_NODE_IMPL_HPP_ +#ifndef RMW_IOX2_RUNTIME_NODE_HPP_ +#define RMW_IOX2_RUNTIME_NODE_HPP_ #include "iox/optional.hpp" #include "rmw/visibility_control.h" -#include "rmw_iceoryx2_cxx/creation_lock.hpp" -#include "rmw_iceoryx2_cxx/error.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/guard_condition_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/iceoryx2.hpp" +#include "rmw_iceoryx2_cxx/impl/common/creation_lock.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error.hpp" +#include "rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/guard_condition.hpp" namespace rmw::iox2 { -class NodeImpl; +class Node; template <> -struct Error +struct Error { using Type = NodeError; }; @@ -36,10 +36,10 @@ struct Error /// The graph data structure is managed by iceoryx2 directly, related operations can be achived via the handle to /// iceoryx2. /// -class RMW_PUBLIC NodeImpl +class RMW_PUBLIC Node { public: - using ErrorType = Error::Type; + using ErrorType = Error::Type; public: /// @brief Constructor for the iceoryx2 implementation of an RMW node @@ -48,7 +48,7 @@ class RMW_PUBLIC NodeImpl /// @param[in] context The context which this node will belong to /// @param[in] name The name of the node /// @param[in] ns The namespace of the node - NodeImpl(CreationLock, iox::optional& error, ContextImpl& context, const char* name, const char* ns); + Node(CreationLock, iox::optional& error, Context& context, const char* name, const char* ns); /// @brief Get the name of the node /// @return The name of the node @@ -60,12 +60,12 @@ class RMW_PUBLIC NodeImpl /// @brief Get the guard condition for notifying of graph events /// @return The guard condition for graph events - auto graph_guard_condition() -> GuardConditionImpl&; + auto graph_guard_condition() -> GuardCondition&; private: const std::string m_name; iox::optional m_iox2; - iox::optional m_graph_guard_condition; + iox::optional m_graph_guard_condition; }; } // namespace rmw::iox2 diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/publisher_impl.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/publisher.hpp similarity index 77% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/publisher_impl.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/publisher.hpp index 0b6cee9..5714467 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/publisher_impl.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/publisher.hpp @@ -7,25 +7,25 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_PUBLISHER_IMPL_HPP_ -#define RMW_IOX2_PUBLISHER_IMPL_HPP_ +#ifndef RMW_IOX2_RUNTIME_PUBLISHER_HPP_ +#define RMW_IOX2_RUNTIME_PUBLISHER_HPP_ #include "iox/optional.hpp" #include "iox/slice.hpp" #include "rmw/visibility_control.h" -#include "rmw_iceoryx2_cxx/creation_lock.hpp" -#include "rmw_iceoryx2_cxx/error.hpp" -#include "rmw_iceoryx2_cxx/iox2/iceoryx2.hpp" -#include "rmw_iceoryx2_cxx/iox2/node_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/sample_registry.hpp" +#include "rmw_iceoryx2_cxx/impl/common/creation_lock.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error.hpp" +#include "rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/node.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/sample_registry.hpp" namespace rmw::iox2 { -class PublisherImpl; +class Publisher; template <> -struct Error +struct Error { using Type = PublisherError; }; @@ -38,19 +38,20 @@ struct Error /// /// It manages the lifecycle of loaned memory and handles the interaction with the /// iceoryx2 middleware layer. -class RMW_PUBLIC PublisherImpl +class RMW_PUBLIC Publisher { public: using Payload = ::iox::Slice; - using ErrorType = Error::Type; + using ErrorType = Error::Type; private: using RawIdType = ::iox2::RawIdType; using IdType = ::iox2::UniquePublisherId; - using Sample = Iceoryx2::InterProcess::SampleMutUninit; - using SampleRegistry = ::rmw::iox2::SampleRegistry; - using Notifier = Iceoryx2::InterProcess::Notifier; - using Publisher = Iceoryx2::InterProcess::Publisher; + + using IceoryxNotifier = Iceoryx2::InterProcess::Notifier; + using IceoryxPublisher = Iceoryx2::InterProcess::Publisher; + using IceoryxSample = Iceoryx2::InterProcess::SampleMutUninit; + using SampleRegistry = SampleRegistry; public: /// @brief Constructor for PublisherImpl @@ -60,12 +61,12 @@ class RMW_PUBLIC PublisherImpl /// @param[in] topic The topic name to publish to /// @param[in] type The message type name /// @param[in] size The maximum message payload size - PublisherImpl(CreationLock, - iox::optional& error, - NodeImpl& node, - const char* topic, - const char* type, - const uint64_t size); + Publisher(CreationLock, + iox::optional& error, + Node& node, + const char* topic, + const char* type, + const uint64_t size); /// @brief Get the unique identifier of this publisher /// @return The unique id or empty optional if failing to retrieve it from iceoryx2 @@ -115,8 +116,8 @@ class RMW_PUBLIC PublisherImpl const uint64_t m_payload_size; iox::optional m_iox_unique_id; - iox::optional m_iox2_notifier; - iox::optional m_iox2_publisher; + iox::optional m_iox2_notifier; + iox::optional m_iox2_publisher; SampleRegistry m_registry; }; diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/sample_registry.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/sample_registry.hpp similarity index 98% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/sample_registry.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/sample_registry.hpp index bc6762c..6f76a22 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/sample_registry.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/sample_registry.hpp @@ -12,7 +12,7 @@ #include "iox/expected.hpp" #include "iox/optional.hpp" -#include "rmw_iceoryx2_cxx/error.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error.hpp" #include @@ -28,7 +28,6 @@ struct Error> using Type = SampleRegistryError; }; - /// @brief Stores samples loaned from iceoryx2 before they are ready for publishing. /// @details Samples loaned from iceoryx2 must be retained until being published or manually released (e.g. by /// subscriptions). diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/subscriber_impl.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/subscriber.hpp similarity index 82% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/subscriber_impl.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/subscriber.hpp index 69c98af..d8601c0 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/subscriber_impl.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/subscriber.hpp @@ -14,17 +14,17 @@ #include "iox/slice.hpp" #include "iox2/unique_port_id.hpp" #include "rmw/visibility_control.h" -#include "rmw_iceoryx2_cxx/creation_lock.hpp" -#include "rmw_iceoryx2_cxx/iox2/node_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/sample_registry.hpp" +#include "rmw_iceoryx2_cxx/impl/common/creation_lock.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/node.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/sample_registry.hpp" namespace rmw::iox2 { -class SubscriberImpl; +class Subscriber; template <> -struct Error +struct Error { using Type = SubscriberError; }; @@ -35,18 +35,18 @@ struct Error /// /// It manages the lifecycle of loaned memory and handles the interaction with the /// iceoryx2 middleware layer. -class RMW_PUBLIC SubscriberImpl +class RMW_PUBLIC Subscriber { public: - using ErrorType = Error::Type; + using ErrorType = Error::Type; using Payload = ::iox::Slice; private: using RawIdType = ::iox2::RawIdType; using IdType = ::iox2::UniqueSubscriberId; - using Sample = Iceoryx2::InterProcess::Sample; - using SampleRegistry = ::rmw::iox2::SampleRegistry; - using Subscriber = Iceoryx2::InterProcess::Subscriber; + using IceoryxSubscriber = Iceoryx2::InterProcess::Subscriber; + using IceoryxSample = Iceoryx2::InterProcess::Sample; + using SampleRegistry = SampleRegistry; public: /// @brief Constructor for SubscriberImpl @@ -55,7 +55,7 @@ class RMW_PUBLIC SubscriberImpl /// @param[in] node The node that owns this subscriber /// @param[in] topic The topic name to subscribe to /// @param[in] type The message type name - SubscriberImpl(CreationLock, iox::optional& error, NodeImpl& node, const char* topic, const char* type); + Subscriber(CreationLock, iox::optional& error, Node& node, const char* topic, const char* type); /// @brief Get the unique identifier of the subscriber /// @return Optional containing the raw ID of the subscriber @@ -93,7 +93,7 @@ class RMW_PUBLIC SubscriberImpl const std::string m_service_name; iox::optional m_iox2_unique_id; - iox::optional m_iox2_subscriber; + iox::optional m_iox2_subscriber; SampleRegistry m_registry; }; diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/waitset_impl.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/waitset.hpp similarity index 88% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/waitset_impl.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/waitset.hpp index 253c270..dcc1c91 100644 --- a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/iox2/waitset_impl.hpp +++ b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/impl/runtime/waitset.hpp @@ -7,19 +7,19 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#ifndef RMW_IOX2_WAITSET_IMPL_HPP_ -#define RMW_IOX2_WAITSET_IMPL_HPP_ +#ifndef RMW_IOX2_RUNTIME_WAITSET_HPP_ +#define RMW_IOX2_RUNTIME_WAITSET_HPP_ #include "iox/duration.hpp" #include "iox/optional.hpp" #include "rmw/visibility_control.h" -#include "rmw_iceoryx2_cxx/creation_lock.hpp" -#include "rmw_iceoryx2_cxx/error.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/guard_condition_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/iceoryx2.hpp" -#include "rmw_iceoryx2_cxx/iox2/subscriber_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/common/creation_lock.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/guard_condition.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/subscriber.hpp" #include @@ -33,13 +33,13 @@ static constexpr bool always_false = false; /// An index used by the RMW to track entities attached to the waitset. using RmwIndex = size_t; -/// Types of entities that the waitset is capable of waiting on +/// Types of entities that the waitset is capable of waiting on. enum class WaitableEntity { SUBSCRIBER, GUARD_CONDITION }; -class WaitSetImpl; +class WaitSet; template <> -struct Error +struct Error { using Type = WaitSetError; }; @@ -48,13 +48,13 @@ struct Error /// @details Waitable entities are tracked in upper layers (i.e. RCL) using indices. /// This implementation maps these indices to iceoryx2 listeners for events signifying /// work is available related to the associated the entities. -class RMW_PUBLIC WaitSetImpl +class RMW_PUBLIC WaitSet { using Duration = ::iox::units::Duration; using ServiceName = ::iox2::ServiceName; - using WaitSet = Iceoryx2::WaitSet::Handle; - using WaitSetGuard = Iceoryx2::WaitSet::Guard; - using WaitSetAttachmentId = Iceoryx2::WaitSet::AttachmentId; + using Guard = Iceoryx2::WaitSet::Guard; + using AttachmentId = Iceoryx2::WaitSet::AttachmentId; + using IceoryxWaitSet = Iceoryx2::WaitSet::Handle; using GuardConditionListener = Iceoryx2::Local::Listener; using SubscriberListener = Iceoryx2::InterProcess::Listener; @@ -107,18 +107,18 @@ class RMW_PUBLIC WaitSetImpl class AttachmentDetails { public: - AttachmentDetails(WaitSetGuard&& guard) + AttachmentDetails(Guard&& guard) : m_guard{std::move(guard)} - , m_id{WaitSetAttachmentId::from_guard(m_guard)} { + , m_id{AttachmentId::from_guard(m_guard)} { } - AttachmentDetails(WaitSetGuard&& guard, const RmwMapping& staged_waitable) + AttachmentDetails(Guard&& guard, const RmwMapping& staged_waitable) : m_guard{std::move(guard)} - , m_id{WaitSetAttachmentId::from_guard(m_guard)} + , m_id{AttachmentId::from_guard(m_guard)} , m_rmw_mapping{staged_waitable} { } - auto id() const -> const WaitSetAttachmentId& { + auto id() const -> const AttachmentId& { return m_id; } @@ -127,8 +127,8 @@ class RMW_PUBLIC WaitSetImpl } private: - WaitSetGuard m_guard; - WaitSetAttachmentId m_id; + Guard m_guard; + AttachmentId m_id; RmwMapping m_rmw_mapping; }; @@ -142,28 +142,28 @@ class RMW_PUBLIC WaitSetImpl }; public: - using ErrorType = Error::Type; + using ErrorType = Error::Type; public: /// @brief Constructor for the WaitSetImpl /// @param[in] lock Creation lock to restrict construction to creation functions /// @param[out] error Optional error that is set if construction fails /// @param[in] context The context to which this waitset is bound to. Must outlive the WaitSetImpl instance. - WaitSetImpl(CreationLock, iox::optional& error, ContextImpl& context); + WaitSet(CreationLock, iox::optional& error, Context& context); /// @brief Maps a guard condition to an RMW index /// @details A listener is created for the mapped guard condition which will be waited on in subsequent wait calls /// unless unmapped /// @param[in] rmw_index The index used to track the guard condition in the RMW /// @param[in] guard_condition The guard condition to be mapped - auto map(RmwIndex rmw_index, GuardConditionImpl& guard_condition) -> iox::expected; + auto map(RmwIndex rmw_index, GuardCondition& guard_condition) -> iox::expected; /// @brief Maps a subscriber to an RMW index /// @details A listener is created for the mapped subscriber which will be waited on in subsequent wait calls /// unless unmapped /// @param[in] rmw_index The index used to track the subscriber in the RMW /// @param[in] subscribe The subscriber to be mapped - auto map(RmwIndex rmw_index, SubscriberImpl& subscriber) -> iox::expected; + auto map(RmwIndex rmw_index, Subscriber& subscriber) -> iox::expected; /// @brief Unmap all currently mapped waitable entities /// @note Unmapped entities will not be waited on in subsequent wait calls @@ -267,8 +267,8 @@ class RMW_PUBLIC WaitSetImpl const StorageIndex storage_index) -> iox::expected; private: - ContextImpl& m_context; - iox::optional m_waitset; + Context& m_context; + iox::optional m_waitset; // Storage for all attached listeners. // Listeners for entities are created on first mapping, and re-used in subsequent calls. @@ -285,7 +285,7 @@ class RMW_PUBLIC WaitSetImpl // =================================================================================================================== template -auto WaitSetImpl::get_storage_index(const std::string& service_name) -> iox::expected { +auto WaitSet::get_storage_index(const std::string& service_name) -> iox::expected { using ::iox::err; using ::iox::ok; @@ -321,7 +321,7 @@ auto WaitSetImpl::get_storage_index(const std::string& service_name) -> iox::exp } template -auto WaitSetImpl::get_stored_listener(StorageIndex storage_index) -> iox::optional*> { +auto WaitSet::get_stored_listener(StorageIndex storage_index) -> iox::optional*> { auto& storage = listener_storage(); if (storage_index < storage.size()) { @@ -331,7 +331,7 @@ auto WaitSetImpl::get_stored_listener(StorageIndex storage_index) -> iox::option } template -inline auto WaitSetImpl::listener_storage() -> std::vector>& { +inline auto WaitSet::listener_storage() -> std::vector>& { if constexpr (std::is_same_v) { return m_guard_condition_listeners; } else if constexpr (std::is_same_v) { @@ -342,8 +342,7 @@ inline auto WaitSetImpl::listener_storage() -> std::vector -auto WaitSetImpl::attach_mapped_listener_impl(const RmwMapping& mapping) - -> iox::expected { +auto WaitSet::attach_mapped_listener_impl(const RmwMapping& mapping) -> iox::expected { using ::iox::err; using ::iox::ok; diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/identifier.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/rmw/identifier.hpp similarity index 100% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/identifier.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/rmw/identifier.hpp diff --git a/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/rmw/serialize.hpp b/rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/rmw/serialization_format.hpp similarity index 100% rename from rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/rmw/serialize.hpp rename to rmw_iceoryx2_cxx/include/rmw_iceoryx2_cxx/rmw/serialization_format.hpp diff --git a/rmw_iceoryx2_cxx/src/iox2/names.cpp b/rmw_iceoryx2_cxx/src/impl/common/names.cpp similarity index 95% rename from rmw_iceoryx2_cxx/src/iox2/names.cpp rename to rmw_iceoryx2_cxx/src/impl/common/names.cpp index 90cb522..8dd6cd8 100644 --- a/rmw_iceoryx2_cxx/src/iox2/names.cpp +++ b/rmw_iceoryx2_cxx/src/impl/common/names.cpp @@ -7,7 +7,7 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#include "rmw_iceoryx2_cxx/iox2/names.hpp" +#include "rmw_iceoryx2_cxx/impl/common/names.hpp" #include diff --git a/rmw_iceoryx2_cxx/src/message/introspect.cpp b/rmw_iceoryx2_cxx/src/impl/message/introspection.cpp similarity index 97% rename from rmw_iceoryx2_cxx/src/message/introspect.cpp rename to rmw_iceoryx2_cxx/src/impl/message/introspection.cpp index c6dbbf7..d3e8bfa 100644 --- a/rmw_iceoryx2_cxx/src/message/introspect.cpp +++ b/rmw_iceoryx2_cxx/src/impl/message/introspection.cpp @@ -7,9 +7,9 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#include "rmw_iceoryx2_cxx/message/introspect.hpp" +#include "rmw_iceoryx2_cxx/impl/message/introspection.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" #include "rosidl_typesupport_fastrtps_cpp/identifier.hpp" #include "rosidl_typesupport_fastrtps_cpp/message_type_support.h" #include "rosidl_typesupport_introspection_c/identifier.h" diff --git a/rmw_iceoryx2_cxx/src/message/serialize.cpp b/rmw_iceoryx2_cxx/src/impl/message/serialization.cpp similarity index 86% rename from rmw_iceoryx2_cxx/src/message/serialize.cpp rename to rmw_iceoryx2_cxx/src/impl/message/serialization.cpp index c396826..df5305d 100644 --- a/rmw_iceoryx2_cxx/src/message/serialize.cpp +++ b/rmw_iceoryx2_cxx/src/impl/message/serialization.cpp @@ -7,4 +7,4 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#include "rmw_iceoryx2_cxx/message/serialize.hpp" +#include "rmw_iceoryx2_cxx/impl/message/serialization.hpp" diff --git a/rmw_iceoryx2_cxx/src/message/typesupport.cpp b/rmw_iceoryx2_cxx/src/impl/message/typesupport.cpp similarity index 100% rename from rmw_iceoryx2_cxx/src/message/typesupport.cpp rename to rmw_iceoryx2_cxx/src/impl/message/typesupport.cpp diff --git a/rmw_iceoryx2_cxx/src/iox2/iceoryx2.cpp b/rmw_iceoryx2_cxx/src/impl/middleware/iceoryx2.cpp similarity index 94% rename from rmw_iceoryx2_cxx/src/iox2/iceoryx2.cpp rename to rmw_iceoryx2_cxx/src/impl/middleware/iceoryx2.cpp index 2bb46f8..aba6406 100644 --- a/rmw_iceoryx2_cxx/src/iox2/iceoryx2.cpp +++ b/rmw_iceoryx2_cxx/src/impl/middleware/iceoryx2.cpp @@ -7,8 +7,8 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#include "rmw_iceoryx2_cxx/iox2/iceoryx2.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" namespace rmw::iox2 { diff --git a/rmw_iceoryx2_cxx/src/iox2/context_impl.cpp b/rmw_iceoryx2_cxx/src/impl/runtime/context.cpp similarity index 87% rename from rmw_iceoryx2_cxx/src/iox2/context_impl.cpp rename to rmw_iceoryx2_cxx/src/impl/runtime/context.cpp index 547331e..c2cdecc 100644 --- a/rmw_iceoryx2_cxx/src/iox2/context_impl.cpp +++ b/rmw_iceoryx2_cxx/src/impl/runtime/context.cpp @@ -7,10 +7,10 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/iox2/names.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/common/names.hpp" rmw_context_impl_s::rmw_context_impl_s(CreationLock, iox::optional& error, const uint32_t id) : m_id{id} { diff --git a/rmw_iceoryx2_cxx/src/iox2/guard_condition_impl.cpp b/rmw_iceoryx2_cxx/src/impl/runtime/guard_condition.cpp similarity index 77% rename from rmw_iceoryx2_cxx/src/iox2/guard_condition_impl.cpp rename to rmw_iceoryx2_cxx/src/impl/runtime/guard_condition.cpp index 00d9f2c..7064387 100644 --- a/rmw_iceoryx2_cxx/src/iox2/guard_condition_impl.cpp +++ b/rmw_iceoryx2_cxx/src/impl/runtime/guard_condition.cpp @@ -7,18 +7,18 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#include "rmw_iceoryx2_cxx/iox2/guard_condition_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/guard_condition.hpp" #include "iox/optional.hpp" #include "iox2/event_id.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/iox2/iceoryx2.hpp" -#include "rmw_iceoryx2_cxx/iox2/names.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/names.hpp" +#include "rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp" namespace rmw::iox2 { -GuardConditionImpl::GuardConditionImpl(CreationLock, iox::optional& error, ContextImpl& context) +GuardCondition::GuardCondition(CreationLock, iox::optional& error, Context& context) : m_trigger_id{context.generate_guard_condition_id()} , m_service_name{names::guard_condition(context.id(), m_trigger_id)} { auto iox2_service_name = Iceoryx2::ServiceName::create(m_service_name.c_str()); @@ -45,21 +45,21 @@ GuardConditionImpl::GuardConditionImpl(CreationLock, iox::optional& e m_iox2_notifier.emplace(std::move(iox2_notifier.value())); }; -auto GuardConditionImpl::trigger_id() const -> uint32_t { +auto GuardCondition::trigger_id() const -> uint32_t { return m_trigger_id; } -auto GuardConditionImpl::unique_id() -> const iox::optional& { +auto GuardCondition::unique_id() -> const iox::optional& { auto& bytes = m_iox2_unique_id->bytes(); return bytes; } -auto GuardConditionImpl::service_name() const -> const std::string& { +auto GuardCondition::service_name() const -> const std::string& { return m_service_name; } -auto GuardConditionImpl::trigger() -> iox::expected { +auto GuardCondition::trigger() -> iox::expected { using ::iox::err; using ::iox::ok; diff --git a/rmw_iceoryx2_cxx/src/iox2/node_impl.cpp b/rmw_iceoryx2_cxx/src/impl/runtime/node.cpp similarity index 64% rename from rmw_iceoryx2_cxx/src/iox2/node_impl.cpp rename to rmw_iceoryx2_cxx/src/impl/runtime/node.cpp index 4e9ce0d..95091d6 100644 --- a/rmw_iceoryx2_cxx/src/iox2/node_impl.cpp +++ b/rmw_iceoryx2_cxx/src/impl/runtime/node.cpp @@ -7,17 +7,16 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#include "rmw_iceoryx2_cxx/iox2/node_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/node.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/iox2/names.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/names.hpp" namespace rmw::iox2 { -NodeImpl::NodeImpl( - CreationLock, iox::optional& error, ContextImpl& context, const char* name, const char* ns) +Node::Node(CreationLock, iox::optional& error, Context& context, const char* name, const char* ns) : m_name{name} { using ::rmw::iox2::create_in_place; namespace names = rmw::iox2::names; @@ -28,22 +27,22 @@ NodeImpl::NodeImpl( return; } - if (auto result = create_in_place(m_graph_guard_condition, context); result.has_error()) { - RMW_IOX2_CHAIN_ERROR_MSG("failed to create GuardConditionImpl"); + if (auto result = create_in_place(m_graph_guard_condition, context); result.has_error()) { + RMW_IOX2_CHAIN_ERROR_MSG("failed to create GuardCondition"); error.emplace(ErrorType::GRAPH_GUARD_CONDITION_CREATION_FAILURE); return; } } -auto NodeImpl::name() const -> const std::string& { +auto Node::name() const -> const std::string& { return m_name; } -auto NodeImpl::iox2() -> Iceoryx2& { +auto Node::iox2() -> Iceoryx2& { return m_iox2.value(); } -auto NodeImpl::graph_guard_condition() -> GuardConditionImpl& { +auto Node::graph_guard_condition() -> GuardCondition& { return m_graph_guard_condition.value(); } diff --git a/rmw_iceoryx2_cxx/src/iox2/publisher_impl.cpp b/rmw_iceoryx2_cxx/src/impl/runtime/publisher.cpp similarity index 81% rename from rmw_iceoryx2_cxx/src/iox2/publisher_impl.cpp rename to rmw_iceoryx2_cxx/src/impl/runtime/publisher.cpp index 5c4c841..0771058 100644 --- a/rmw_iceoryx2_cxx/src/iox2/publisher_impl.cpp +++ b/rmw_iceoryx2_cxx/src/impl/runtime/publisher.cpp @@ -7,22 +7,21 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#include "rmw_iceoryx2_cxx/iox2/publisher_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/publisher.hpp" -#include "iox2/sample_mut.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/iox2/iceoryx2.hpp" -#include "rmw_iceoryx2_cxx/iox2/names.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/names.hpp" +#include "rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp" namespace rmw::iox2 { -PublisherImpl::PublisherImpl(CreationLock, - iox::optional& error, - NodeImpl& node, - const char* topic, - const char* type, - const uint64_t payload_size) +Publisher::Publisher(CreationLock, + iox::optional& error, + Node& node, + const char* topic, + const char* type, + const uint64_t payload_size) : m_topic{topic} , m_type{type} , m_service_name{::rmw::iox2::names::topic(topic)} @@ -76,28 +75,28 @@ PublisherImpl::PublisherImpl(CreationLock, } -auto PublisherImpl::unique_id() -> const iox::optional& { +auto Publisher::unique_id() -> const iox::optional& { auto& bytes = m_iox_unique_id->bytes(); return bytes; } -auto PublisherImpl::topic() const -> const std::string& { +auto Publisher::topic() const -> const std::string& { return m_topic; } -auto PublisherImpl::type() const -> const std::string& { +auto Publisher::type() const -> const std::string& { return m_type; } -auto PublisherImpl::service_name() const -> const std::string& { +auto Publisher::service_name() const -> const std::string& { return m_service_name; } -auto PublisherImpl::payload_size() const -> uint64_t { +auto Publisher::payload_size() const -> uint64_t { return m_payload_size; } -auto PublisherImpl::loan() -> iox::expected { +auto Publisher::loan() -> iox::expected { using iox::err; using iox::ok; @@ -112,7 +111,7 @@ auto PublisherImpl::loan() -> iox::expected { return ok(static_cast(ptr)); } -auto PublisherImpl::return_loan(void* loaned_memory) -> iox::expected { +auto Publisher::return_loan(void* loaned_memory) -> iox::expected { using ::iox::err; using ::iox::ok; @@ -125,7 +124,7 @@ auto PublisherImpl::return_loan(void* loaned_memory) -> iox::expected iox::expected { +auto Publisher::publish_loan(void* loaned_memory) -> iox::expected { using ::iox::err; using ::iox::ok; @@ -149,7 +148,7 @@ auto PublisherImpl::publish_loan(void* loaned_memory) -> iox::expected iox::expected { +auto Publisher::publish_copy(const void* msg, uint64_t size) -> iox::expected { using ::iox::err; using ::iox::ImmutableSlice; using ::iox::ok; diff --git a/rmw_iceoryx2_cxx/src/iox2/subscriber_impl.cpp b/rmw_iceoryx2_cxx/src/impl/runtime/subscriber.cpp similarity index 81% rename from rmw_iceoryx2_cxx/src/iox2/subscriber_impl.cpp rename to rmw_iceoryx2_cxx/src/impl/runtime/subscriber.cpp index 982e788..fcfa1c3 100644 --- a/rmw_iceoryx2_cxx/src/iox2/subscriber_impl.cpp +++ b/rmw_iceoryx2_cxx/src/impl/runtime/subscriber.cpp @@ -7,17 +7,16 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#include "rmw_iceoryx2_cxx/iox2/subscriber_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/subscriber.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/iox2/iceoryx2.hpp" -#include "rmw_iceoryx2_cxx/iox2/names.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/names.hpp" +#include "rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp" namespace rmw::iox2 { -SubscriberImpl::SubscriberImpl( - CreationLock, iox::optional& error, NodeImpl& node, const char* topic, const char* type) +Subscriber::Subscriber(CreationLock, iox::optional& error, Node& node, const char* topic, const char* type) : m_topic{topic} , m_type{type} , m_service_name{::rmw::iox2::names::topic(topic)} { @@ -53,24 +52,24 @@ SubscriberImpl::SubscriberImpl( m_iox2_subscriber.emplace(std::move(iox2_subscriber.value())); } -auto SubscriberImpl::unique_id() -> const iox::optional& { +auto Subscriber::unique_id() -> const iox::optional& { auto& bytes = m_iox2_unique_id->bytes(); return bytes; } -auto SubscriberImpl::topic() const -> const std::string& { +auto Subscriber::topic() const -> const std::string& { return m_topic; } -auto SubscriberImpl::type() const -> const std::string& { +auto Subscriber::type() const -> const std::string& { return m_type; } -auto SubscriberImpl::service_name() const -> const std::string& { +auto Subscriber::service_name() const -> const std::string& { return m_service_name; } -auto SubscriberImpl::take_copy(void* dest) -> iox::expected { +auto Subscriber::take_copy(void* dest) -> iox::expected { using iox::err; using iox::nullopt; using iox::ok; @@ -92,7 +91,7 @@ auto SubscriberImpl::take_copy(void* dest) -> iox::expected { } } -auto SubscriberImpl::take_loan() -> iox::expected, ErrorType> { +auto Subscriber::take_loan() -> iox::expected, ErrorType> { using iox::err; using iox::nullopt; using iox::ok; @@ -114,7 +113,7 @@ auto SubscriberImpl::take_loan() -> iox::expected, Er } } -auto SubscriberImpl::return_loan(void* loaned_memory) -> iox::expected { +auto Subscriber::return_loan(void* loaned_memory) -> iox::expected { using ::iox::err; using ::iox::ok; diff --git a/rmw_iceoryx2_cxx/src/iox2/waitset_impl.cpp b/rmw_iceoryx2_cxx/src/impl/runtime/waitset.cpp similarity index 84% rename from rmw_iceoryx2_cxx/src/iox2/waitset_impl.cpp rename to rmw_iceoryx2_cxx/src/impl/runtime/waitset.cpp index c014f95..1a47882 100644 --- a/rmw_iceoryx2_cxx/src/iox2/waitset_impl.cpp +++ b/rmw_iceoryx2_cxx/src/impl/runtime/waitset.cpp @@ -7,17 +7,17 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#include "rmw_iceoryx2_cxx/iox2/waitset_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/waitset.hpp" #include "iox2/callback_progression.hpp" #include "iox2/waitset.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/log.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/log.hpp" namespace rmw::iox2 { -WaitSetImpl::WaitSetImpl(CreationLock, iox::optional& error, ContextImpl& context) +WaitSet::WaitSet(CreationLock, iox::optional& error, Context& context) : m_context{context} { auto waitset = Iceoryx2::WaitSet::create(); if (waitset.has_error()) { @@ -28,7 +28,7 @@ WaitSetImpl::WaitSetImpl(CreationLock, iox::optional& error, Conte m_waitset.emplace(std::move(waitset.value())); } -auto WaitSetImpl::map(RmwIndex rmw_index, GuardConditionImpl& guard_condition) -> iox::expected { +auto WaitSet::map(RmwIndex rmw_index, GuardCondition& guard_condition) -> iox::expected { using ::iox::err; using ::iox::ok; @@ -41,7 +41,7 @@ auto WaitSetImpl::map(RmwIndex rmw_index, GuardConditionImpl& guard_condition) - } } -auto WaitSetImpl::map(RmwIndex rmw_index, SubscriberImpl& subscriber) -> iox::expected { +auto WaitSet::map(RmwIndex rmw_index, Subscriber& subscriber) -> iox::expected { using ::iox::err; using ::iox::ok; @@ -54,9 +54,9 @@ auto WaitSetImpl::map(RmwIndex rmw_index, SubscriberImpl& subscriber) -> iox::ex } } -auto WaitSetImpl::map_stored_listener(WaitableEntity waitable_type, - StorageIndex storage_index, - RmwIndex rmw_index) -> void { +auto WaitSet::map_stored_listener(WaitableEntity waitable_type, + StorageIndex storage_index, + RmwIndex rmw_index) -> void { auto it = std::find_if(m_mapping.begin(), m_mapping.end(), [waitable_type, storage_index](const auto& staged) { return staged.waitable_type == waitable_type && staged.storage_index == storage_index; }); @@ -66,13 +66,12 @@ auto WaitSetImpl::map_stored_listener(WaitableEntity waitable_type, } } -auto WaitSetImpl::unmap_all() -> void { +auto WaitSet::unmap_all() -> void { // Detaching removes the mapping, but the listener remains in the storage for re-use in subsequent calls. m_mapping.clear(); } -auto WaitSetImpl::wait(const iox::optional& timeout) - -> iox::expected, ErrorType> { +auto WaitSet::wait(const iox::optional& timeout) -> iox::expected, ErrorType> { using ::iox::err; using ::iox::ok; using ::iox2::CallbackProgression; @@ -146,15 +145,15 @@ auto WaitSetImpl::wait(const iox::optional& timeout) return ok(ctx.result); } -auto WaitSetImpl::zero_timeout(const iox::optional& timeout) const -> bool { +auto WaitSet::zero_timeout(const iox::optional& timeout) const -> bool { return timeout.has_value() && timeout.value() == Duration::zero(); } -auto WaitSetImpl::no_timeout(const iox::optional& timeout) const -> bool { +auto WaitSet::no_timeout(const iox::optional& timeout) const -> bool { return !timeout.has_value(); } -auto WaitSetImpl::attach_timeout(const Duration& timeout, WaitContext& ctx) -> ::iox::expected { +auto WaitSet::attach_timeout(const Duration& timeout, WaitContext& ctx) -> ::iox::expected { using ::iox::err; using ::iox::ok; @@ -166,7 +165,7 @@ auto WaitSetImpl::attach_timeout(const Duration& timeout, WaitContext& ctx) -> : return ok(); } -auto WaitSetImpl::attach_mapped_listeners(WaitContext& ctx) -> iox::expected { +auto WaitSet::attach_mapped_listeners(WaitContext& ctx) -> iox::expected { using ::iox::err; using ::iox::ok; @@ -181,7 +180,7 @@ auto WaitSetImpl::attach_mapped_listeners(WaitContext& ctx) -> iox::expected iox::expected { +auto WaitSet::attach_mapped_listener(const RmwMapping& mapping) -> iox::expected { using ::iox::err; using ::iox::ok; @@ -196,8 +195,8 @@ auto WaitSetImpl::attach_mapped_listener(const RmwMapping& mapping) -> iox::expe } } -auto WaitSetImpl::process_trigger(const WaitableEntity waitable_type, - const StorageIndex storage_index) -> iox::expected { +auto WaitSet::process_trigger(const WaitableEntity waitable_type, + const StorageIndex storage_index) -> iox::expected { using ::iox::err; using ::iox::ok; diff --git a/rmw_iceoryx2_cxx/src/rmw/client.cpp b/rmw_iceoryx2_cxx/src/rmw/client.cpp index 72daab0..04d7fdf 100644 --- a/rmw_iceoryx2_cxx/src/rmw/client.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/client.cpp @@ -11,9 +11,9 @@ #include "rmw/ret_types.h" #include "rmw/rmw.h" #include "rmw/validate_full_topic_name.h" -#include "rmw_iceoryx2_cxx/allocator.hpp" -#include "rmw_iceoryx2_cxx/ensure.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/allocator.hpp" +#include "rmw_iceoryx2_cxx/impl/common/ensure.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" extern "C" { diff --git a/rmw_iceoryx2_cxx/src/rmw/event.cpp b/rmw_iceoryx2_cxx/src/rmw/event.cpp index 9ad8656..7bf27ac 100644 --- a/rmw_iceoryx2_cxx/src/rmw/event.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/event.cpp @@ -9,7 +9,7 @@ #include "rmw/ret_types.h" #include "rmw/rmw.h" -#include "rmw_iceoryx2_cxx/ensure.hpp" +#include "rmw_iceoryx2_cxx/impl/common/ensure.hpp" extern "C" { diff --git a/rmw_iceoryx2_cxx/src/rmw/gid.cpp b/rmw_iceoryx2_cxx/src/rmw/gid.cpp index 7517a73..f0edea2 100644 --- a/rmw_iceoryx2_cxx/src/rmw/gid.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/gid.cpp @@ -10,34 +10,34 @@ #include "iox/assertions_addendum.hpp" #include "rmw/ret_types.h" #include "rmw/rmw.h" -#include "rmw_iceoryx2_cxx/allocator.hpp" -#include "rmw_iceoryx2_cxx/ensure.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/iox2/publisher_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/common/allocator.hpp" +#include "rmw_iceoryx2_cxx/impl/common/ensure.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/publisher.hpp" -rmw_ret_t rmw_get_gid_for_publisher(const rmw_publisher_t* publisher, rmw_gid_t* gid) { +rmw_ret_t rmw_get_gid_for_publisher(const rmw_publisher_t* rmw_publisher, rmw_gid_t* rmw_gid) { // Invariants ---------------------------------------------------------------------------------- - RMW_IOX2_ENSURE_NOT_NULL(publisher, RMW_RET_INVALID_ARGUMENT); - RMW_IOX2_ENSURE_IMPLEMENTATION(publisher->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); - RMW_IOX2_ENSURE_NOT_NULL(gid, RMW_RET_INVALID_ARGUMENT); + RMW_IOX2_ENSURE_NOT_NULL(rmw_publisher, RMW_RET_INVALID_ARGUMENT); + RMW_IOX2_ENSURE_IMPLEMENTATION(rmw_publisher->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); + RMW_IOX2_ENSURE_NOT_NULL(rmw_gid, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- - using ::rmw::iox2::PublisherImpl; + // ementation ------------------------------------------------------------------------------- + using ::rmw::iox2::Publisher; using ::rmw::iox2::unsafe_cast; - auto publisher_impl = unsafe_cast(publisher->data); + auto publisher_impl = unsafe_cast(rmw_publisher->data); if (publisher_impl.has_error()) { - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve PublisherImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve Publisher"); return RMW_RET_ERROR; } if (auto id = publisher_impl.value()->unique_id(); id.has_value()) { - gid->implementation_identifier = rmw_get_implementation_identifier(); - std::copy(id.value().data(), id.value().data() + RMW_GID_STORAGE_SIZE, gid->data); + rmw_gid->implementation_identifier = rmw_get_implementation_identifier(); + std::copy(id.value().data(), id.value().data() + RMW_GID_STORAGE_SIZE, rmw_gid->data); return RMW_RET_OK; } - RMW_IOX2_CHAIN_ERROR_MSG("unable to retrieve UniquePortId for PublisherImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("unable to retrieve UniquePortId for Publisher"); return RMW_RET_ERROR; } @@ -47,7 +47,7 @@ rmw_ret_t rmw_get_gid_for_client(const rmw_client_t* client, rmw_gid_t* gid) { RMW_IOX2_ENSURE_IMPLEMENTATION(client->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); RMW_IOX2_ENSURE_NOT_NULL(gid, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- return RMW_RET_UNSUPPORTED; } @@ -59,7 +59,7 @@ rmw_ret_t rmw_compare_gids_equal(const rmw_gid_t* gid1, const rmw_gid_t* gid2, b RMW_IOX2_ENSURE_IMPLEMENTATION(gid1->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); RMW_IOX2_ENSURE_IMPLEMENTATION(gid2->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- // NOTE: In iceoryx2, GIDs for different entities (Publishers, Notifiers, etc.) have unique types. // Thus, these IDs may have the same value but the type system prevents them from being considered equal. // In C, only the raw value is worked with. This might cause problems. diff --git a/rmw_iceoryx2_cxx/src/rmw/graph.cpp b/rmw_iceoryx2_cxx/src/rmw/graph.cpp index 787a5f9..6728ec1 100644 --- a/rmw_iceoryx2_cxx/src/rmw/graph.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/graph.cpp @@ -19,15 +19,15 @@ #include "rmw/validate_full_topic_name.h" #include "rmw/validate_namespace.h" #include "rmw/validate_node_name.h" -#include "rmw_iceoryx2_cxx/allocator.hpp" -#include "rmw_iceoryx2_cxx/defaults.hpp" -#include "rmw_iceoryx2_cxx/ensure.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/iox2/iceoryx2.hpp" -#include "rmw_iceoryx2_cxx/iox2/names.hpp" -#include "rmw_iceoryx2_cxx/iox2/node_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/publisher_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/subscriber_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/common/allocator.hpp" +#include "rmw_iceoryx2_cxx/impl/common/defaults.hpp" +#include "rmw_iceoryx2_cxx/impl/common/ensure.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/names.hpp" +#include "rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/node.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/publisher.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/subscriber.hpp" #include #include @@ -269,8 +269,8 @@ rmw_ret_t rmw_get_node_names_with_enclaves(const rmw_node_t* node, rmw_ret_t rmw_count_publishers(const rmw_node_t* node, const char* topic_name, size_t* count) { using ::rmw::iox2::Iceoryx2; - using ::rmw::iox2::NodeImpl; - using ::rmw::iox2::PublisherImpl; + using ::rmw::iox2::Node; + using ::rmw::iox2::Publisher; using ::rmw::iox2::unsafe_cast; namespace names = rmw::iox2::names; @@ -282,7 +282,7 @@ rmw_ret_t rmw_count_publishers(const rmw_node_t* node, const char* topic_name, s RMW_IOX2_ENSURE_NOT_NULL(count, RMW_RET_INVALID_ARGUMENT); // Implementation ------------------------------------------------------------------------------- - auto node_impl_result = unsafe_cast(node->data); + auto node_impl_result = unsafe_cast(node->data); if (node_impl_result.has_error()) { RMW_IOX2_CHAIN_ERROR_MSG("failed to get NodeImpl"); return RMW_RET_ERROR; @@ -299,7 +299,7 @@ rmw_ret_t rmw_count_publishers(const rmw_node_t* node, const char* topic_name, s auto service_result = node_impl->iox2() .ipc() .service_builder(iox2_service_name.value()) - .publish_subscribe() + .publish_subscribe() .open_or_create(); if (service_result.has_error()) { RMW_IOX2_CHAIN_ERROR_MSG("failed to open service"); @@ -364,8 +364,8 @@ rmw_ret_t rmw_get_publishers_info_by_topic(const rmw_node_t* node, rmw_ret_t rmw_count_subscribers(const rmw_node_t* node, const char* topic_name, size_t* count) { using ::rmw::iox2::Iceoryx2; - using ::rmw::iox2::NodeImpl; - using ::rmw::iox2::SubscriberImpl; + using ::rmw::iox2::Node; + using ::rmw::iox2::Subscriber; using ::rmw::iox2::unsafe_cast; namespace names = rmw::iox2::names; @@ -377,7 +377,7 @@ rmw_ret_t rmw_count_subscribers(const rmw_node_t* node, const char* topic_name, RMW_IOX2_ENSURE_NOT_NULL(count, RMW_RET_INVALID_ARGUMENT); // Implementation ------------------------------------------------------------------------------- - auto node_impl_result = unsafe_cast(node->data); + auto node_impl_result = unsafe_cast(node->data); if (node_impl_result.has_error()) { RMW_IOX2_CHAIN_ERROR_MSG("failed to get NodeImpl"); return RMW_RET_ERROR; @@ -394,7 +394,7 @@ rmw_ret_t rmw_count_subscribers(const rmw_node_t* node, const char* topic_name, auto service_result = node_impl->iox2() .ipc() .service_builder(iox2_service_name.value()) - .publish_subscribe() + .publish_subscribe() .open_or_create(); if (service_result.has_error()) { RMW_IOX2_CHAIN_ERROR_MSG("failed to open service"); diff --git a/rmw_iceoryx2_cxx/src/rmw/guard_condition.cpp b/rmw_iceoryx2_cxx/src/rmw/guard_condition.cpp index 96bca02..2248f92 100644 --- a/rmw_iceoryx2_cxx/src/rmw/guard_condition.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/guard_condition.cpp @@ -7,15 +7,15 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT +#include "rmw_iceoryx2_cxx/impl/runtime/guard_condition.hpp" #include "rmw/allocators.h" #include "rmw/ret_types.h" #include "rmw/rmw.h" -#include "rmw_iceoryx2_cxx/allocator.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/ensure.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/guard_condition_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/common/allocator.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/common/ensure.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" extern "C" { rmw_guard_condition_t* rmw_create_guard_condition(rmw_context_t* context) { @@ -24,12 +24,12 @@ rmw_guard_condition_t* rmw_create_guard_condition(rmw_context_t* context) { RMW_IOX2_ENSURE_IMPLEMENTATION(context->implementation_identifier, nullptr); RMW_IOX2_ENSURE_NOT_NULL(context->impl, nullptr); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- using ::rmw::iox2::allocate; using ::rmw::iox2::create_in_place; using ::rmw::iox2::deallocate; using ::rmw::iox2::destruct; - using ::rmw::iox2::GuardConditionImpl; + using ::rmw::iox2::GuardCondition; using ::rmw::iox2::unsafe_cast; auto* guard_condition = rmw_guard_condition_allocate(); @@ -41,18 +41,18 @@ rmw_guard_condition_t* rmw_create_guard_condition(rmw_context_t* context) { guard_condition->context = context; guard_condition->implementation_identifier = rmw_get_implementation_identifier(); - auto ptr = allocate(); + auto ptr = allocate(); if (ptr.has_error()) { rmw_guard_condition_free(guard_condition); - RMW_IOX2_CHAIN_ERROR_MSG("failed to allocate memory for GuardConditionImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to allocate memory for GuardCondition"); return nullptr; } - if (create_in_place(ptr.value(), *context->impl).has_error()) { - destruct(ptr.value()); - deallocate(ptr.value()); + if (create_in_place(ptr.value(), *context->impl).has_error()) { + destruct(ptr.value()); + deallocate(ptr.value()); rmw_guard_condition_free(guard_condition); - RMW_IOX2_CHAIN_ERROR_MSG("failed to construct GuardConditionImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to construct GuardCondition"); return nullptr; } guard_condition->data = ptr.value(); @@ -65,13 +65,13 @@ rmw_ret_t rmw_destroy_guard_condition(rmw_guard_condition_t* guard_condition) { RMW_IOX2_ENSURE_NOT_NULL(guard_condition, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_IMPLEMENTATION(guard_condition->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- using rmw::iox2::deallocate; using rmw::iox2::destruct; - using rmw::iox2::GuardConditionImpl; + using rmw::iox2::GuardCondition; if (guard_condition->data) { - destruct(guard_condition->data); + destruct(guard_condition->data); deallocate(guard_condition->data); } rmw_guard_condition_free(guard_condition); @@ -84,12 +84,12 @@ rmw_ret_t rmw_trigger_guard_condition(const rmw_guard_condition_t* guard_conditi RMW_IOX2_ENSURE_NOT_NULL(guard_condition, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_IMPLEMENTATION(guard_condition->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); - // Implementation ------------------------------------------------------------------------------- - using rmw::iox2::GuardConditionImpl; + // ementation ------------------------------------------------------------------------------- + using rmw::iox2::GuardCondition; using rmw::iox2::unsafe_cast; auto result = RMW_RET_OK; - unsafe_cast(guard_condition->data).and_then([&result](auto impl) { + unsafe_cast(guard_condition->data).and_then([&result](auto impl) { if (impl->trigger().has_error()) { RMW_IOX2_CHAIN_ERROR_MSG("failed to trigger guard condition"); result = RMW_RET_ERROR; diff --git a/rmw_iceoryx2_cxx/src/rmw/identifier.cpp b/rmw_iceoryx2_cxx/src/rmw/identifier.cpp index ac247ae..3d02755 100644 --- a/rmw_iceoryx2_cxx/src/rmw/identifier.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/identifier.cpp @@ -7,7 +7,7 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT -#include "rmw_iceoryx2_cxx/identifier.hpp" +#include "rmw_iceoryx2_cxx/rmw/identifier.hpp" extern "C" { diff --git a/rmw_iceoryx2_cxx/src/rmw/init.cpp b/rmw_iceoryx2_cxx/src/rmw/init.cpp index 8577d85..b68c73a 100644 --- a/rmw_iceoryx2_cxx/src/rmw/init.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/init.cpp @@ -11,12 +11,12 @@ #include "rcutils/strdup.h" #include "rmw/init_options.h" #include "rmw/ret_types.h" -#include "rmw_iceoryx2_cxx/allocator.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/ensure.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/identifier.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/common/allocator.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/common/ensure.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" +#include "rmw_iceoryx2_cxx/rmw/identifier.hpp" constexpr const char* DEFAULT_ENCLAVE = ""; diff --git a/rmw_iceoryx2_cxx/src/rmw/node.cpp b/rmw_iceoryx2_cxx/src/rmw/node.cpp index cf57c7b..d03fd58 100644 --- a/rmw_iceoryx2_cxx/src/rmw/node.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/node.cpp @@ -7,19 +7,19 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT +#include "rmw_iceoryx2_cxx/impl/runtime/node.hpp" #include "rmw/allocators.h" #include "rmw/ret_types.h" #include "rmw/rmw.h" #include "rmw/validate_namespace.h" #include "rmw/validate_node_name.h" -#include "rmw_iceoryx2_cxx/allocator.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/ensure.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/identifier.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/node_impl.hpp" -#include "rmw_iceoryx2_cxx/log.hpp" +#include "rmw_iceoryx2_cxx/impl/common/allocator.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/common/ensure.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/log.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" +#include "rmw_iceoryx2_cxx/rmw/identifier.hpp" extern "C" { @@ -29,13 +29,13 @@ namespace void inline destroy_node_impl(rmw_node_t* node) noexcept { using rmw::iox2::deallocate; using rmw::iox2::destruct; - using rmw::iox2::NodeImpl; + using rmw::iox2::Node; if (node) { deallocate(node->name); deallocate(node->namespace_); if (node->data) { - destruct(node->data); + destruct(node->data); deallocate(node->data); } rmw_node_free(node); @@ -54,13 +54,13 @@ rmw_node_t* rmw_create_node(rmw_context_t* context, const char* name, const char RMW_IOX2_ENSURE_INITIALIZED(context, nullptr); RMW_IOX2_ENSURE_IMPLEMENTATION(context->implementation_identifier, nullptr); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- using ::rmw::iox2::allocate; using ::rmw::iox2::allocate_copy; using ::rmw::iox2::create_in_place; using ::rmw::iox2::deallocate; using ::rmw::iox2::destruct; - using ::rmw::iox2::NodeImpl; + using ::rmw::iox2::Node; RMW_IOX2_LOG_DEBUG("Creating node '%s' in namespace '%s'", name, namespace_); @@ -88,19 +88,19 @@ rmw_node_t* rmw_create_node(rmw_context_t* context, const char* name, const char } node->namespace_ = namespace_ptr.value(); - auto ptr = allocate(); + auto ptr = allocate(); if (ptr.has_error()) { destroy_node_impl(node); - RMW_IOX2_CHAIN_ERROR_MSG("failed to allocate memory for NodeImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to allocate memory for Node"); return nullptr; } - if (auto construction = create_in_place(ptr.value(), *context->impl, node->name, node->namespace_); + if (auto construction = create_in_place(ptr.value(), *context->impl, node->name, node->namespace_); construction.has_error()) { - destruct(ptr.value()); - deallocate(ptr.value()); + destruct(ptr.value()); + deallocate(ptr.value()); destroy_node_impl(node); - RMW_IOX2_CHAIN_ERROR_MSG("failed to construct NodeImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to construct Node"); return nullptr; } node->data = ptr.value(); @@ -114,7 +114,7 @@ rmw_ret_t rmw_destroy_node(rmw_node_t* node) { RMW_IOX2_ENSURE_NOT_NULL(node, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_IMPLEMENTATION(node->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- RMW_IOX2_LOG_DEBUG("Destroying node '%s' in namespace '%s'", node->name, node->namespace_); @@ -130,8 +130,8 @@ const rmw_guard_condition_t* rmw_node_get_graph_guard_condition(const rmw_node_t RMW_IOX2_ENSURE_NOT_NULL(node->context->impl, nullptr); RMW_IOX2_ENSURE_IMPLEMENTATION(node->implementation_identifier, nullptr); - // Implementation ------------------------------------------------------------------------------- - using rmw::iox2::NodeImpl; + // ementation ------------------------------------------------------------------------------- + using rmw::iox2::Node; using rmw::iox2::unsafe_cast; auto* guard_condition = rmw_guard_condition_allocate(); @@ -143,9 +143,9 @@ const rmw_guard_condition_t* rmw_node_get_graph_guard_condition(const rmw_node_t guard_condition->implementation_identifier = rmw_get_implementation_identifier(); guard_condition->context = node->context; - auto node_impl = unsafe_cast(node->data); + auto node_impl = unsafe_cast(node->data); if (node_impl.has_error()) { - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve NodeImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve Node"); return nullptr; } diff --git a/rmw_iceoryx2_cxx/src/rmw/publisher.cpp b/rmw_iceoryx2_cxx/src/rmw/publisher.cpp index e8165bf..5fbf4ea 100644 --- a/rmw_iceoryx2_cxx/src/rmw/publisher.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/publisher.cpp @@ -7,20 +7,20 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT +#include "rmw_iceoryx2_cxx/impl/runtime/publisher.hpp" #include "iox/assertions_addendum.hpp" #include "rmw/allocators.h" #include "rmw/get_network_flow_endpoints.h" #include "rmw/ret_types.h" #include "rmw/rmw.h" #include "rmw/validate_full_topic_name.h" -#include "rmw_iceoryx2_cxx/allocator.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/ensure.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/publisher_impl.hpp" -#include "rmw_iceoryx2_cxx/log.hpp" -#include "rmw_iceoryx2_cxx/message/introspect.hpp" +#include "rmw_iceoryx2_cxx/impl/common/allocator.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/common/ensure.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/log.hpp" +#include "rmw_iceoryx2_cxx/impl/message/introspection.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" extern "C" { @@ -44,7 +44,7 @@ rmw_publisher_t* rmw_create_publisher(const rmw_node_t* node, } RMW_IOX2_ENSURE_NOT_NULL(publisher_options, nullptr); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- using ::rmw::iox2::allocate; using ::rmw::iox2::allocate_copy; using ::rmw::iox2::create_in_place; @@ -52,8 +52,8 @@ rmw_publisher_t* rmw_create_publisher(const rmw_node_t* node, using ::rmw::iox2::destruct; using ::rmw::iox2::is_pod; using ::rmw::iox2::message_size; - using ::rmw::iox2::NodeImpl; - using ::rmw::iox2::PublisherImpl; + using ::rmw::iox2::Node; + using ::rmw::iox2::Publisher; using ::rmw::iox2::unsafe_cast; RMW_IOX2_LOG_DEBUG("Creating publisher to '%s'", topic_name); @@ -81,28 +81,28 @@ rmw_publisher_t* rmw_create_publisher(const rmw_node_t* node, publisher->topic_name = ptr.value(); } - auto node_impl = unsafe_cast(node->data); + auto node_impl = unsafe_cast(node->data); if (node_impl.has_error()) { rmw_publisher_free(publisher); - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve NodeImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve Node"); return nullptr; } - if (auto ptr = allocate(); ptr.has_error()) { + if (auto ptr = allocate(); ptr.has_error()) { rmw_publisher_free(publisher); - RMW_IOX2_CHAIN_ERROR_MSG("failed to allocate memory for PublisherImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to allocate memory for Publisher"); return nullptr; } else { - if (create_in_place(ptr.value(), - *node_impl.value(), - topic_name, - type_support->typesupport_identifier, - message_size(type_support)) + if (create_in_place(ptr.value(), + *node_impl.value(), + topic_name, + type_support->typesupport_identifier, + message_size(type_support)) .has_error()) { - destruct(ptr.value()); - deallocate(ptr.value()); + destruct(ptr.value()); + deallocate(ptr.value()); rmw_publisher_free(publisher); - RMW_IOX2_CHAIN_ERROR_MSG("failed to construct PublisherImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to construct Publisher"); return nullptr; } else { publisher->data = ptr.value(); @@ -119,15 +119,15 @@ rmw_ret_t rmw_destroy_publisher(rmw_node_t* node, rmw_publisher_t* publisher) { RMW_IOX2_ENSURE_NOT_NULL(publisher, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_IMPLEMENTATION(publisher->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- using ::rmw::iox2::deallocate; using ::rmw::iox2::destruct; - using ::rmw::iox2::PublisherImpl; + using ::rmw::iox2::Publisher; RMW_IOX2_LOG_DEBUG("Destroying publisher to '%s'", publisher->topic_name); if (publisher->data) { - destruct(publisher->data); + destruct(publisher->data); deallocate(publisher->data); } rmw_publisher_free(publisher); @@ -141,7 +141,7 @@ rmw_ret_t rmw_publisher_count_matched_subscriptions(const rmw_publisher_t* publi RMW_IOX2_ENSURE_NOT_NULL(subscription_count, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_IMPLEMENTATION(publisher->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- return RMW_RET_UNSUPPORTED; } @@ -151,7 +151,7 @@ rmw_ret_t rmw_publisher_get_actual_qos(const rmw_publisher_t* publisher, rmw_qos RMW_IOX2_ENSURE_IMPLEMENTATION(publisher->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); RMW_IOX2_ENSURE_NOT_NULL(qos, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- *qos = rmw_qos_profile_default; return RMW_RET_OK; @@ -168,15 +168,15 @@ rmw_ret_t rmw_borrow_loaned_message(const rmw_publisher_t* publisher, RMW_IOX2_ENSURE_NOT_NULL(ros_message, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_NULL(*ros_message, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- - using ::rmw::iox2::PublisherImpl; + // ementation ------------------------------------------------------------------------------- + using ::rmw::iox2::Publisher; using ::rmw::iox2::unsafe_cast; RMW_IOX2_LOG_DEBUG("New loan from '%s'", publisher->topic_name); - auto publisher_impl = unsafe_cast(publisher->data); + auto publisher_impl = unsafe_cast(publisher->data); if (publisher_impl.has_error()) { - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve PublisherImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve Publisher"); return RMW_RET_ERROR; } @@ -196,15 +196,15 @@ rmw_ret_t rmw_return_loaned_message_from_publisher(const rmw_publisher_t* publis RMW_IOX2_ENSURE_NOT_NULL(loaned_message, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_IMPLEMENTATION(publisher->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); - // Implementation ------------------------------------------------------------------------------- - using ::rmw::iox2::PublisherImpl; + // ementation ------------------------------------------------------------------------------- + using ::rmw::iox2::Publisher; using ::rmw::iox2::unsafe_cast; RMW_IOX2_LOG_DEBUG("Releasing loan to '%s'", publisher->topic_name); - auto publisher_impl = unsafe_cast(publisher->data); + auto publisher_impl = unsafe_cast(publisher->data); if (publisher_impl.has_error()) { - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve PublisherImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve Publisher"); return RMW_RET_ERROR; } @@ -223,15 +223,15 @@ rmw_publish(const rmw_publisher_t* publisher, const void* ros_message, rmw_publi RMW_IOX2_ENSURE_IMPLEMENTATION(publisher->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); RMW_IOX2_ENSURE_NOT_NULL(ros_message, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- - using ::rmw::iox2::PublisherImpl; + // ementation ------------------------------------------------------------------------------- + using ::rmw::iox2::Publisher; using ::rmw::iox2::unsafe_cast; RMW_IOX2_LOG_DEBUG("Publishing copy to '%s'", publisher->topic_name); - auto publisher_impl = unsafe_cast(publisher->data); + auto publisher_impl = unsafe_cast(publisher->data); if (publisher_impl.has_error()) { - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve PublisherImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve Publisher"); return RMW_RET_ERROR; } @@ -259,15 +259,15 @@ rmw_ret_t rmw_publish_loaned_message(const rmw_publisher_t* publisher, RMW_IOX2_ENSURE_IMPLEMENTATION(publisher->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); RMW_IOX2_ENSURE_NOT_NULL(ros_message, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- - using ::rmw::iox2::PublisherImpl; + // ementation ------------------------------------------------------------------------------- + using ::rmw::iox2::Publisher; using ::rmw::iox2::unsafe_cast; RMW_IOX2_LOG_DEBUG("Publishing loan to '%s'", publisher->topic_name); - auto publisher_impl = unsafe_cast(publisher->data); + auto publisher_impl = unsafe_cast(publisher->data); if (publisher_impl.has_error()) { - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve PublisherImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve Publisher"); return RMW_RET_ERROR; } @@ -287,7 +287,7 @@ rmw_ret_t rmw_publish_serialized_message(const rmw_publisher_t* publisher, RMW_IOX2_ENSURE_IMPLEMENTATION(publisher->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); RMW_IOX2_ENSURE_NOT_NULL(serialized_message, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- return RMW_RET_UNSUPPORTED; } diff --git a/rmw_iceoryx2_cxx/src/rmw/qos.cpp b/rmw_iceoryx2_cxx/src/rmw/qos.cpp index 5dc5d32..cb2877e 100644 --- a/rmw_iceoryx2_cxx/src/rmw/qos.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/qos.cpp @@ -9,7 +9,7 @@ #include "rmw/qos_profiles.h" #include "rmw/ret_types.h" -#include "rmw_iceoryx2_cxx/ensure.hpp" +#include "rmw_iceoryx2_cxx/impl/common/ensure.hpp" extern "C" { rmw_ret_t rmw_qos_profile_check_compatible(const rmw_qos_profile_t publisher_profile, diff --git a/rmw_iceoryx2_cxx/src/rmw/serialize.cpp b/rmw_iceoryx2_cxx/src/rmw/serialize.cpp index 7dd8a47..707d6b3 100644 --- a/rmw_iceoryx2_cxx/src/rmw/serialize.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/serialize.cpp @@ -10,9 +10,9 @@ #include "rmw/dynamic_message_type_support.h" #include "rmw/ret_types.h" #include "rmw/rmw.h" -#include "rmw_iceoryx2_cxx/ensure.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/message/introspect.hpp" +#include "rmw_iceoryx2_cxx/impl/common/ensure.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/message/introspection.hpp" const char* const rmw_iox2_serialization_format = "iceoryx2"; diff --git a/rmw_iceoryx2_cxx/src/rmw/service.cpp b/rmw_iceoryx2_cxx/src/rmw/service.cpp index dab1305..b1be145 100644 --- a/rmw_iceoryx2_cxx/src/rmw/service.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/service.cpp @@ -11,9 +11,9 @@ #include "rmw/ret_types.h" #include "rmw/rmw.h" #include "rmw/validate_full_topic_name.h" -#include "rmw_iceoryx2_cxx/allocator.hpp" -#include "rmw_iceoryx2_cxx/ensure.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/allocator.hpp" +#include "rmw_iceoryx2_cxx/impl/common/ensure.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" extern "C" { diff --git a/rmw_iceoryx2_cxx/src/rmw/subscription.cpp b/rmw_iceoryx2_cxx/src/rmw/subscription.cpp index 4da1b0e..4df0013 100644 --- a/rmw_iceoryx2_cxx/src/rmw/subscription.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/subscription.cpp @@ -14,14 +14,14 @@ #include "rmw/ret_types.h" #include "rmw/rmw.h" #include "rmw/validate_full_topic_name.h" -#include "rmw_iceoryx2_cxx/allocator.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/ensure.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/subscriber_impl.hpp" -#include "rmw_iceoryx2_cxx/log.hpp" -#include "rmw_iceoryx2_cxx/message/introspect.hpp" +#include "rmw_iceoryx2_cxx/impl/common/allocator.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/common/ensure.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/log.hpp" +#include "rmw_iceoryx2_cxx/impl/message/introspection.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/subscriber.hpp" extern "C" { @@ -45,15 +45,15 @@ rmw_subscription_t* rmw_create_subscription(const rmw_node_t* node, } RMW_IOX2_ENSURE_NOT_NULL(subscription_options, nullptr); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- using ::rmw::iox2::allocate; using ::rmw::iox2::allocate_copy; using ::rmw::iox2::create_in_place; using ::rmw::iox2::deallocate; using ::rmw::iox2::destruct; using ::rmw::iox2::is_pod; - using ::rmw::iox2::NodeImpl; - using ::rmw::iox2::SubscriberImpl; + using ::rmw::iox2::Node; + using ::rmw::iox2::Subscriber; using ::rmw::iox2::unsafe_cast; RMW_IOX2_LOG_DEBUG("Creating subscription to '%s'", topic_name); @@ -81,25 +81,25 @@ rmw_subscription_t* rmw_create_subscription(const rmw_node_t* node, subscription->topic_name = ptr.value(); } - auto node_impl = unsafe_cast(node->data); + auto node_impl = unsafe_cast(node->data); if (node_impl.has_error()) { rmw_subscription_free(subscription); - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve NodeImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve Node"); return nullptr; } - if (auto ptr = allocate(); ptr.has_error()) { + if (auto ptr = allocate(); ptr.has_error()) { rmw_subscription_free(subscription); - RMW_IOX2_CHAIN_ERROR_MSG("failed to allocate memory for SubscriberImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to allocate memory for Subscriber"); return nullptr; } else { - if (create_in_place( + if (create_in_place( ptr.value(), *node_impl.value(), topic_name, type_support->typesupport_identifier) .has_error()) { - destruct(ptr.value()); - deallocate(ptr.value()); + destruct(ptr.value()); + deallocate(ptr.value()); rmw_subscription_free(subscription); - RMW_IOX2_CHAIN_ERROR_MSG("failed to construct SubscriberImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to construct Subscriber"); return nullptr; } else { subscription->data = ptr.value(); @@ -116,15 +116,15 @@ rmw_ret_t rmw_destroy_subscription(rmw_node_t* node, rmw_subscription_t* subscri RMW_IOX2_ENSURE_NOT_NULL(subscription, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_IMPLEMENTATION(subscription->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- using ::rmw::iox2::deallocate; using ::rmw::iox2::destruct; - using ::rmw::iox2::SubscriberImpl; + using ::rmw::iox2::Subscriber; RMW_IOX2_LOG_DEBUG("Destroying subscription to '%s'", subscription->topic_name); if (subscription->data) { - destruct(subscription->data); + destruct(subscription->data); deallocate(subscription->data); } rmw_subscription_free(subscription); @@ -138,7 +138,7 @@ rmw_ret_t rmw_subscription_count_matched_publishers(const rmw_subscription_t* su RMW_IOX2_ENSURE_IMPLEMENTATION(subscription->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); RMW_IOX2_ENSURE_NOT_NULL(publisher_count, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- return RMW_RET_UNSUPPORTED; } @@ -148,7 +148,7 @@ rmw_ret_t rmw_subscription_get_actual_qos(const rmw_subscription_t* subscription RMW_IOX2_ENSURE_IMPLEMENTATION(subscription->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); RMW_IOX2_ENSURE_NOT_NULL(qos, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- *qos = rmw_qos_profile_default; return RMW_RET_OK; @@ -166,8 +166,8 @@ rmw_ret_t rmw_take_loaned_message(const rmw_subscription_t* subscription, RMW_IOX2_ENSURE_NOT_NULL(loaned_message, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_NULL(*loaned_message, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- - using ::rmw::iox2::SubscriberImpl; + // ementation ------------------------------------------------------------------------------- + using ::rmw::iox2::Subscriber; using ::rmw::iox2::unsafe_cast; (void)allocation; // not used @@ -178,9 +178,9 @@ rmw_ret_t rmw_take_loaned_message(const rmw_subscription_t* subscription, RMW_IOX2_LOG_DEBUG("Retrieving loan from from '%s'", subscription->topic_name); - auto subscriber_impl = unsafe_cast(subscription->data); + auto subscriber_impl = unsafe_cast(subscription->data); if (subscriber_impl.has_error()) { - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve SubscriberImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve Subscriber"); return RMW_RET_ERROR; } @@ -212,7 +212,7 @@ rmw_ret_t rmw_take_loaned_message_with_info(const rmw_subscription_t* subscripti RMW_IOX2_ENSURE_CAN_LOAN(subscription, RMW_RET_UNSUPPORTED); RMW_IOX2_ENSURE_NOT_NULL(taken, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- (void)message_info; // TODO: support this return rmw_take_loaned_message(subscription, loaned_message, taken, allocation); @@ -225,15 +225,15 @@ rmw_ret_t rmw_return_loaned_message_from_subscription(const rmw_subscription_t* RMW_IOX2_ENSURE_CAN_LOAN(subscription, RMW_RET_UNSUPPORTED); RMW_IOX2_ENSURE_NOT_NULL(loaned_message, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- - using ::rmw::iox2::SubscriberImpl; + // ementation ------------------------------------------------------------------------------- + using ::rmw::iox2::Subscriber; using ::rmw::iox2::unsafe_cast; RMW_IOX2_LOG_DEBUG("Releasing loan to '%s'", subscription->topic_name); - auto subscriber_impl = unsafe_cast(subscription->data); + auto subscriber_impl = unsafe_cast(subscription->data); if (subscriber_impl.has_error()) { - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve SubscriberImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve Subscriber"); return RMW_RET_ERROR; } @@ -257,15 +257,15 @@ rmw_ret_t rmw_take(const rmw_subscription_t* subscription, RMW_IOX2_ENSURE_NOT_NULL(ros_message, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_NOT_NULL(taken, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- - using ::rmw::iox2::SubscriberImpl; + // ementation ------------------------------------------------------------------------------- + using ::rmw::iox2::Subscriber; using ::rmw::iox2::unsafe_cast; RMW_IOX2_LOG_DEBUG("Retrieving copy from '%s'", subscription->topic_name); - auto subscriber_impl = unsafe_cast(subscription->data); + auto subscriber_impl = unsafe_cast(subscription->data); if (subscriber_impl.has_error()) { - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve SubscriberImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve Subscriber"); return RMW_RET_ERROR; } @@ -301,7 +301,7 @@ rmw_ret_t rmw_take_with_info(const rmw_subscription_t* subscription, RMW_IOX2_ENSURE_NOT_NULL(message_info, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_IMPLEMENTATION(subscription->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- return rmw_take(subscription, ros_message, taken, allocation); } @@ -322,7 +322,7 @@ rmw_ret_t rmw_take_sequence(const rmw_subscription_t* subscription, return RMW_RET_INVALID_ARGUMENT; } - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- return RMW_RET_UNSUPPORTED; } @@ -336,7 +336,7 @@ rmw_ret_t rmw_take_serialized_message(const rmw_subscription_t* subscription, RMW_IOX2_ENSURE_NOT_NULL(serialized_message, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_NOT_NULL(taken, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- return RMW_RET_UNSUPPORTED; } @@ -352,7 +352,7 @@ rmw_ret_t rmw_take_serialized_message_with_info(const rmw_subscription_t* subscr RMW_IOX2_ENSURE_NOT_NULL(taken, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_NOT_NULL(message_info, RMW_RET_INVALID_ARGUMENT); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- return RMW_RET_UNSUPPORTED; } diff --git a/rmw_iceoryx2_cxx/src/rmw/waitset.cpp b/rmw_iceoryx2_cxx/src/rmw/waitset.cpp index 712e324..d9fe138 100644 --- a/rmw_iceoryx2_cxx/src/rmw/waitset.cpp +++ b/rmw_iceoryx2_cxx/src/rmw/waitset.cpp @@ -7,15 +7,15 @@ // // SPDX-License-Identifier: Apache-2.0 OR MIT +#include "rmw_iceoryx2_cxx/impl/runtime/waitset.hpp" #include "rmw/allocators.h" #include "rmw/ret_types.h" #include "rmw/rmw.h" -#include "rmw_iceoryx2_cxx/allocator.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/ensure.hpp" -#include "rmw_iceoryx2_cxx/error_message.hpp" -#include "rmw_iceoryx2_cxx/iox2/waitset_impl.hpp" -#include "rmw_iceoryx2_cxx/log.hpp" +#include "rmw_iceoryx2_cxx/impl/common/allocator.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/common/ensure.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/log.hpp" #include @@ -26,12 +26,12 @@ rmw_wait_set_t* rmw_create_wait_set(rmw_context_t* context, size_t max_condition RMW_IOX2_ENSURE_NOT_NULL(context->impl, nullptr); RMW_IOX2_ENSURE_IMPLEMENTATION(context->implementation_identifier, nullptr); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- using ::rmw::iox2::allocate; using ::rmw::iox2::create_in_place; using ::rmw::iox2::deallocate; using ::rmw::iox2::destruct; - using ::rmw::iox2::WaitSetImpl; + using ::rmw::iox2::WaitSet; (void)max_conditions; // not needed @@ -44,16 +44,16 @@ rmw_wait_set_t* rmw_create_wait_set(rmw_context_t* context, size_t max_condition } wait_set->implementation_identifier = rmw_get_implementation_identifier(); - if (auto ptr = allocate(); ptr.has_error()) { + if (auto ptr = allocate(); ptr.has_error()) { rmw_wait_set_free(wait_set); - RMW_IOX2_CHAIN_ERROR_MSG("failed to allocate memory for WaitSetImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to allocate memory for WaitSet"); return nullptr; } else { - if (create_in_place(ptr.value(), *context->impl).has_error()) { - destruct(ptr.value()); - deallocate(ptr.value()); + if (create_in_place(ptr.value(), *context->impl).has_error()) { + destruct(ptr.value()); + deallocate(ptr.value()); rmw_wait_set_free(wait_set); - RMW_IOX2_CHAIN_ERROR_MSG("failed to construct WaitSetImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to construct WaitSet"); return nullptr; } else { wait_set->data = ptr.value(); @@ -68,15 +68,15 @@ rmw_ret_t rmw_destroy_wait_set(rmw_wait_set_t* wait_set) { RMW_IOX2_ENSURE_NOT_NULL(wait_set, RMW_RET_INVALID_ARGUMENT); RMW_IOX2_ENSURE_IMPLEMENTATION(wait_set->implementation_identifier, RMW_RET_INCORRECT_RMW_IMPLEMENTATION); - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- using ::rmw::iox2::deallocate; using ::rmw::iox2::destruct; - using ::rmw::iox2::WaitSetImpl; + using ::rmw::iox2::WaitSet; RMW_IOX2_LOG_DEBUG("Destroying waitset"); if (wait_set->data) { - destruct(wait_set->data); + destruct(wait_set->data); deallocate(wait_set->data); } @@ -110,22 +110,22 @@ rmw_ret_t rmw_wait(rmw_subscriptions_t* subscriptions, } } - // Implementation ------------------------------------------------------------------------------- + // ementation ------------------------------------------------------------------------------- using ::iox::units::Duration; - using ::rmw::iox2::GuardConditionImpl; - using ::rmw::iox2::SubscriberImpl; + using ::rmw::iox2::GuardCondition; + using ::rmw::iox2::Subscriber; using ::rmw::iox2::unsafe_cast; using ::rmw::iox2::WaitableEntity; - using ::rmw::iox2::WaitSetImpl; + using ::rmw::iox2::WaitSet; iox::optional timeout; if (wait_timeout) { timeout.emplace(Duration::fromSeconds(wait_timeout->sec) + Duration::fromNanoseconds(wait_timeout->nsec)); } - auto ptr = unsafe_cast(wait_set->data); + auto ptr = unsafe_cast(wait_set->data); if (ptr.has_error()) { - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve WaitSetImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve WaitSet"); return RMW_RET_ERROR; } auto waitset_impl = ptr.value(); @@ -133,14 +133,14 @@ rmw_ret_t rmw_wait(rmw_subscriptions_t* subscriptions, // Attach all guard_conditions to waitset if (guard_conditions) { for (size_t index = 0; index < guard_conditions->guard_condition_count; index++) { - auto guard_condition = unsafe_cast(guard_conditions->guard_conditions[index]); + auto guard_condition = unsafe_cast(guard_conditions->guard_conditions[index]); if (guard_condition.has_error()) { - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve GuardConditionImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve GuardCondition"); return RMW_RET_ERROR; } if (auto result = waitset_impl->map(index, *guard_condition.value()); result.has_error()) { // TODO: maybe detach previously attached elements? Detach all? - RMW_IOX2_CHAIN_ERROR_MSG("failed to attach GuardConditionImpl to WaitSetImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to attach GuardCondition to WaitSet"); return RMW_RET_ERROR; } } @@ -149,14 +149,14 @@ rmw_ret_t rmw_wait(rmw_subscriptions_t* subscriptions, // Attach all subscriptions to waitset if (subscriptions) { for (size_t index = 0; index < subscriptions->subscriber_count; index++) { - auto subscriber = unsafe_cast(subscriptions->subscribers[index]); + auto subscriber = unsafe_cast(subscriptions->subscribers[index]); if (subscriber.has_error()) { - RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve SubscriberImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to retrieve Subscriber"); return RMW_RET_ERROR; } if (auto result = waitset_impl->map(index, *subscriber.value()); result.has_error()) { // TODO: maybe detach previously attached elements? Detach all? - RMW_IOX2_CHAIN_ERROR_MSG("failed to attach SubscriberImpl to WaitSetImpl"); + RMW_IOX2_CHAIN_ERROR_MSG("failed to attach Subscriber to WaitSet"); return RMW_RET_ERROR; } } diff --git a/rmw_iceoryx2_cxx/test/test_iox2_context_impl.cpp b/rmw_iceoryx2_cxx/test/test_impl_context.cpp similarity index 74% rename from rmw_iceoryx2_cxx/test/test_iox2_context_impl.cpp rename to rmw_iceoryx2_cxx/test/test_impl_context.cpp index b59c6d8..ef9597a 100644 --- a/rmw_iceoryx2_cxx/test/test_iox2_context_impl.cpp +++ b/rmw_iceoryx2_cxx/test/test_impl_context.cpp @@ -10,8 +10,8 @@ #include #include "iox/optional.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" #include "testing/base.hpp" namespace @@ -19,7 +19,7 @@ namespace using namespace rmw::iox2::testing; -class RmwContextImplTest : public TestBase +class ContextTest : public TestBase { protected: void SetUp() override { @@ -29,11 +29,11 @@ class RmwContextImplTest : public TestBase } }; -TEST_F(RmwContextImplTest, construction) { - using ::rmw::iox2::ContextImpl; +TEST_F(ContextTest, construction) { + using ::rmw::iox2::Context; using ::rmw::iox2::create_in_place; - iox::optional context_storage; + iox::optional context_storage; ASSERT_FALSE(create_in_place(context_storage, test_id()).has_error()); } diff --git a/rmw_iceoryx2_cxx/test/test_iox2_guard_condition_impl.cpp b/rmw_iceoryx2_cxx/test/test_impl_guard_condition.cpp similarity index 66% rename from rmw_iceoryx2_cxx/test/test_iox2_guard_condition_impl.cpp rename to rmw_iceoryx2_cxx/test/test_impl_guard_condition.cpp index c0040c8..04cb891 100644 --- a/rmw_iceoryx2_cxx/test/test_iox2_guard_condition_impl.cpp +++ b/rmw_iceoryx2_cxx/test/test_impl_guard_condition.cpp @@ -10,10 +10,10 @@ #include #include "iox/optional.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/error.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/guard_condition_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/guard_condition.hpp" #include "testing/base.hpp" namespace @@ -21,7 +21,7 @@ namespace using namespace rmw::iox2::testing; -class RmwGuardConditionImplTest : public TestBase +class GuardConditionTest : public TestBase { protected: void SetUp() override { @@ -31,17 +31,17 @@ class RmwGuardConditionImplTest : public TestBase } }; -TEST_F(RmwGuardConditionImplTest, construction) { - using ::rmw::iox2::ContextImpl; +TEST_F(GuardConditionTest, construction) { + using ::rmw::iox2::Context; using ::rmw::iox2::create_in_place; + using ::rmw::iox2::GuardCondition; using ::rmw::iox2::GuardConditionError; - using ::rmw::iox2::GuardConditionImpl; - iox::optional context_storage; + iox::optional context_storage; create_in_place(context_storage, test_id()).expect("failed to create context for guard condition creation"); auto& context = context_storage.value(); - iox::optional guard_condition_storage; + iox::optional guard_condition_storage; ASSERT_FALSE(create_in_place(guard_condition_storage, context).has_error()); } diff --git a/rmw_iceoryx2_cxx/test/test_iox2_message_introspection.cpp b/rmw_iceoryx2_cxx/test/test_impl_message_introspection.cpp similarity index 96% rename from rmw_iceoryx2_cxx/test/test_iox2_message_introspection.cpp rename to rmw_iceoryx2_cxx/test/test_impl_message_introspection.cpp index a87843a..e400d43 100644 --- a/rmw_iceoryx2_cxx/test/test_iox2_message_introspection.cpp +++ b/rmw_iceoryx2_cxx/test/test_impl_message_introspection.cpp @@ -9,7 +9,7 @@ #include -#include "rmw_iceoryx2_cxx/message/introspect.hpp" +#include "rmw_iceoryx2_cxx/impl/message/introspection.hpp" #include "rmw_iceoryx2_cxx_test_msgs/msg/defaults.hpp" #include "rmw_iceoryx2_cxx_test_msgs/msg/strings.hpp" #include "testing/base.hpp" diff --git a/rmw_iceoryx2_cxx/test/test_iox2_node_impl.cpp b/rmw_iceoryx2_cxx/test/test_impl_node.cpp similarity index 68% rename from rmw_iceoryx2_cxx/test/test_iox2_node_impl.cpp rename to rmw_iceoryx2_cxx/test/test_impl_node.cpp index d5c53f9..0ab8bd2 100644 --- a/rmw_iceoryx2_cxx/test/test_iox2_node_impl.cpp +++ b/rmw_iceoryx2_cxx/test/test_impl_node.cpp @@ -10,9 +10,9 @@ #include #include "iox/optional.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/node_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/node.hpp" #include "testing/base.hpp" namespace @@ -20,7 +20,7 @@ namespace using namespace rmw::iox2::testing; -class RmwNodeImplTest : public TestBase +class NodeTest : public TestBase { protected: void SetUp() override { @@ -30,18 +30,18 @@ class RmwNodeImplTest : public TestBase } }; -TEST_F(RmwNodeImplTest, construction) { +TEST_F(NodeTest, construction) { using ::iox::optional; - using ::rmw::iox2::ContextImpl; + using ::rmw::iox2::Context; using ::rmw::iox2::create_in_place; - using ::rmw::iox2::NodeImpl; + using ::rmw::iox2::Node; - iox::optional context_storage; + iox::optional context_storage; create_in_place(context_storage, test_id()).expect("failed to create context for publisher creation"); auto& context = context_storage.value(); - iox::optional node_storage; - ASSERT_FALSE(create_in_place(node_storage, context, "MyNode", "RmwNodeImplTest").has_error()); + iox::optional node_storage; + ASSERT_FALSE(create_in_place(node_storage, context, "MyNode", "RmwNodeTest").has_error()); } } // namespace diff --git a/rmw_iceoryx2_cxx/test/test_iox2_publisher_impl.cpp b/rmw_iceoryx2_cxx/test/test_impl_publisher.cpp similarity index 69% rename from rmw_iceoryx2_cxx/test/test_iox2_publisher_impl.cpp rename to rmw_iceoryx2_cxx/test/test_impl_publisher.cpp index d78add5..aadd58c 100644 --- a/rmw_iceoryx2_cxx/test/test_iox2_publisher_impl.cpp +++ b/rmw_iceoryx2_cxx/test/test_impl_publisher.cpp @@ -10,9 +10,9 @@ #include #include "iox/optional.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/publisher_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/publisher.hpp" #include "testing/assertions.hpp" #include "testing/base.hpp" @@ -21,7 +21,7 @@ namespace using namespace rmw::iox2::testing; -class RmwPublisherImplTest : public TestBase +class PublisherTest : public TestBase { protected: void SetUp() override { @@ -31,22 +31,22 @@ class RmwPublisherImplTest : public TestBase } }; -TEST_F(RmwPublisherImplTest, construction) { - using ::rmw::iox2::ContextImpl; +TEST_F(PublisherTest, construction) { + using ::rmw::iox2::Context; using ::rmw::iox2::create_in_place; - using ::rmw::iox2::NodeImpl; - using ::rmw::iox2::PublisherImpl; + using ::rmw::iox2::Node; + using ::rmw::iox2::Publisher; - iox::optional context_storage; + iox::optional context_storage; create_in_place(context_storage, test_id()).expect("failed to create context for publisher creation"); auto& context = context_storage.value(); - iox::optional node_storage; - create_in_place(node_storage, context, "Node", "RmwPublisherImplTest") + iox::optional node_storage; + create_in_place(node_storage, context, "Node", "RmwPublisherTest") .expect("failed to create node for publisher creation"); auto& node = node_storage.value(); - iox::optional publisher_storage; + iox::optional publisher_storage; ASSERT_FALSE(create_in_place(publisher_storage, node, "Topic", "Type", 8).has_error()); } diff --git a/rmw_iceoryx2_cxx/test/test_iox2_sample_registry.cpp b/rmw_iceoryx2_cxx/test/test_impl_sample_registry.cpp similarity index 95% rename from rmw_iceoryx2_cxx/test/test_iox2_sample_registry.cpp rename to rmw_iceoryx2_cxx/test/test_impl_sample_registry.cpp index 9986c89..de4a72c 100644 --- a/rmw_iceoryx2_cxx/test/test_iox2_sample_registry.cpp +++ b/rmw_iceoryx2_cxx/test/test_impl_sample_registry.cpp @@ -13,8 +13,8 @@ #include "iox2/node.hpp" #include "iox2/sample_mut_uninit.hpp" #include "iox2/service_name.hpp" -#include "rmw_iceoryx2_cxx/iox2/iceoryx2.hpp" -#include "rmw_iceoryx2_cxx/iox2/sample_registry.hpp" +#include "rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/sample_registry.hpp" #include "testing/base.hpp" namespace diff --git a/rmw_iceoryx2_cxx/test/test_iox2_subscriber_impl.cpp b/rmw_iceoryx2_cxx/test/test_impl_subscriber.cpp similarity index 69% rename from rmw_iceoryx2_cxx/test/test_iox2_subscriber_impl.cpp rename to rmw_iceoryx2_cxx/test/test_impl_subscriber.cpp index d2fac93..9de3383 100644 --- a/rmw_iceoryx2_cxx/test/test_iox2_subscriber_impl.cpp +++ b/rmw_iceoryx2_cxx/test/test_impl_subscriber.cpp @@ -10,9 +10,9 @@ #include #include "iox/optional.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/subscriber_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/subscriber.hpp" #include "testing/assertions.hpp" #include "testing/base.hpp" @@ -21,7 +21,7 @@ namespace using namespace rmw::iox2::testing; -class RmwSubscriberImplTest : public TestBase +class SubscriberTest : public TestBase { protected: void SetUp() override { @@ -31,22 +31,22 @@ class RmwSubscriberImplTest : public TestBase } }; -TEST_F(RmwSubscriberImplTest, construction) { - using ::rmw::iox2::ContextImpl; +TEST_F(SubscriberTest, construction) { + using ::rmw::iox2::Context; using ::rmw::iox2::create_in_place; - using ::rmw::iox2::NodeImpl; - using ::rmw::iox2::SubscriberImpl; + using ::rmw::iox2::Node; + using ::rmw::iox2::Subscriber; - iox::optional context_storage; + iox::optional context_storage; create_in_place(context_storage, test_id()).expect("failed to create context for subscriber creation"); auto& context = context_storage.value(); - iox::optional node_storage; - create_in_place(node_storage, context, "Node", "RmwPublisherImplTest") + iox::optional node_storage; + create_in_place(node_storage, context, "Node", "RmwPublisherTest") .expect("failed to create node for publisher creation"); auto& node = node_storage.value(); - iox::optional subscriber_storage; + iox::optional subscriber_storage; ASSERT_FALSE(create_in_place(subscriber_storage, node, "Topic", "Type").has_error()); } diff --git a/rmw_iceoryx2_cxx/test/test_iox2_waitset_impl.cpp b/rmw_iceoryx2_cxx/test/test_impl_waitset.cpp similarity index 72% rename from rmw_iceoryx2_cxx/test/test_iox2_waitset_impl.cpp rename to rmw_iceoryx2_cxx/test/test_impl_waitset.cpp index ca110e4..99afc8d 100644 --- a/rmw_iceoryx2_cxx/test/test_iox2_waitset_impl.cpp +++ b/rmw_iceoryx2_cxx/test/test_impl_waitset.cpp @@ -10,8 +10,8 @@ #include #include "iox/optional.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/iox2/waitset_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/waitset.hpp" #include "testing/base.hpp" namespace @@ -19,7 +19,7 @@ namespace using namespace rmw::iox2::testing; -class RmwWaitSetImplTest : public TestBase +class WaitSetTest : public TestBase { protected: void SetUp() override { @@ -29,16 +29,16 @@ class RmwWaitSetImplTest : public TestBase } }; -TEST_F(RmwWaitSetImplTest, construction) { - using ::rmw::iox2::ContextImpl; +TEST_F(WaitSetTest, construction) { + using ::rmw::iox2::Context; using ::rmw::iox2::create_in_place; - using ::rmw::iox2::WaitSetImpl; + using ::rmw::iox2::WaitSet; - iox::optional context_storage; + iox::optional context_storage; create_in_place(context_storage, test_id()).expect("failed to create context for waitset creation"); auto& context = context_storage.value(); - iox::optional waitset_storage; + iox::optional waitset_storage; ASSERT_FALSE(create_in_place(waitset_storage, context).has_error()); } diff --git a/rmw_iceoryx2_cxx/test/test_rmw_allocator.cpp b/rmw_iceoryx2_cxx/test/test_rmw_allocator.cpp index c284d0a..a7d5867 100644 --- a/rmw_iceoryx2_cxx/test/test_rmw_allocator.cpp +++ b/rmw_iceoryx2_cxx/test/test_rmw_allocator.cpp @@ -9,7 +9,7 @@ #include -#include "rmw_iceoryx2_cxx/allocator.hpp" +#include "rmw_iceoryx2_cxx/impl/common/allocator.hpp" #include "testing/base.hpp" namespace diff --git a/rmw_iceoryx2_cxx/test/test_rmw_gid.cpp b/rmw_iceoryx2_cxx/test/test_rmw_gid.cpp index 198d89b..d7565af 100644 --- a/rmw_iceoryx2_cxx/test/test_rmw_gid.cpp +++ b/rmw_iceoryx2_cxx/test/test_rmw_gid.cpp @@ -9,7 +9,7 @@ #include -#include "rmw_iceoryx2_cxx/allocator.hpp" +#include "rmw_iceoryx2_cxx/impl/common/allocator.hpp" #include "rmw_iceoryx2_cxx_test_msgs/msg/defaults.hpp" #include "testing/assertions.hpp" #include "testing/base.hpp" diff --git a/rmw_iceoryx2_cxx/test/test_rmw_guard_condition.cpp b/rmw_iceoryx2_cxx/test/test_rmw_guard_condition.cpp index 445321d..1ff1dbb 100644 --- a/rmw_iceoryx2_cxx/test/test_rmw_guard_condition.cpp +++ b/rmw_iceoryx2_cxx/test/test_rmw_guard_condition.cpp @@ -11,12 +11,12 @@ #include "iox/optional.hpp" #include "rmw/rmw.h" -#include "rmw_iceoryx2_cxx/allocator.hpp" -#include "rmw_iceoryx2_cxx/create.hpp" -#include "rmw_iceoryx2_cxx/iox2/context_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/guard_condition_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/iceoryx2.hpp" -#include "rmw_iceoryx2_cxx/iox2/names.hpp" +#include "rmw_iceoryx2_cxx/impl/common/allocator.hpp" +#include "rmw_iceoryx2_cxx/impl/common/create.hpp" +#include "rmw_iceoryx2_cxx/impl/common/names.hpp" +#include "rmw_iceoryx2_cxx/impl/middleware/iceoryx2.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/context.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/guard_condition.hpp" #include "testing/assertions.hpp" #include "testing/base.hpp" @@ -77,7 +77,7 @@ TEST_F(RmwGuardConditionTest, create_and_destroy) { } TEST_F(RmwGuardConditionTest, trigger) { - using ::rmw::iox2::GuardConditionImpl; + using ::rmw::iox2::GuardCondition; using ::rmw::iox2::unsafe_cast; namespace names = ::rmw::iox2::names; @@ -86,7 +86,7 @@ TEST_F(RmwGuardConditionTest, trigger) { EXPECT_NE(guard_condition->data, nullptr); // TODO: An easier way to access the guard condition ID? - auto impl = unsafe_cast(guard_condition->data).expect("failed to get guard condition impl"); + auto impl = unsafe_cast(guard_condition->data).expect("failed to get guard condition impl"); auto listener = iox2_listener(names::guard_condition(guard_condition->context->instance_id, impl->trigger_id())); EXPECT_RMW_OK(rmw_trigger_guard_condition(guard_condition)); diff --git a/rmw_iceoryx2_cxx/test/test_rmw_init.cpp b/rmw_iceoryx2_cxx/test/test_rmw_init.cpp index 3281ec7..feeedb1 100644 --- a/rmw_iceoryx2_cxx/test/test_rmw_init.cpp +++ b/rmw_iceoryx2_cxx/test/test_rmw_init.cpp @@ -11,7 +11,7 @@ #include "rmw/init.h" #include "rmw/init_options.h" -#include "rmw_iceoryx2_cxx/identifier.hpp" +#include "rmw_iceoryx2_cxx/rmw/identifier.hpp" #include "testing/assertions.hpp" #include "testing/base.hpp" diff --git a/rmw_iceoryx2_cxx/test/test_rmw_node.cpp b/rmw_iceoryx2_cxx/test/test_rmw_node.cpp index 6a03572..68cdfa2 100644 --- a/rmw_iceoryx2_cxx/test/test_rmw_node.cpp +++ b/rmw_iceoryx2_cxx/test/test_rmw_node.cpp @@ -10,7 +10,7 @@ #include #include "rmw/rmw.h" -#include "rmw_iceoryx2_cxx/identifier.hpp" +#include "rmw_iceoryx2_cxx/rmw/identifier.hpp" #include "testing/assertions.hpp" #include "testing/base.hpp" diff --git a/rmw_iceoryx2_cxx/test/test_rmw_waitset.cpp b/rmw_iceoryx2_cxx/test/test_rmw_waitset.cpp index f694638..976bea8 100644 --- a/rmw_iceoryx2_cxx/test/test_rmw_waitset.cpp +++ b/rmw_iceoryx2_cxx/test/test_rmw_waitset.cpp @@ -13,8 +13,8 @@ #include "rmw/qos_profiles.h" #include "rmw/rmw.h" #include "rmw/subscription_options.h" -#include "rmw_iceoryx2_cxx/iox2/guard_condition_impl.hpp" -#include "rmw_iceoryx2_cxx/iox2/subscriber_impl.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/guard_condition.hpp" +#include "rmw_iceoryx2_cxx/impl/runtime/subscriber.hpp" #include "rmw_iceoryx2_cxx_test_msgs/msg/defaults.hpp" #include "testing/assertions.hpp" #include "testing/base.hpp" @@ -30,8 +30,8 @@ using namespace rmw::iox2::testing; /// By containing the complexity here, the hope is that tests are more readable. class WaitSetTestContext { - using GuardConditionImpl = rmw::iox2::GuardConditionImpl; - using SubscriberImpl = rmw::iox2::SubscriberImpl; + using GuardCondition = rmw::iox2::GuardCondition; + using Subscriber = rmw::iox2::Subscriber; // Keeps track of typesupports used by added publishers struct PublisherDetails @@ -90,9 +90,9 @@ class WaitSetTestContext /// This is expected by rmw_wait(). rmw_guard_conditions_t* guard_conditions_array() { auto guard_condition_data = - static_cast(rmw_allocate(sizeof(GuardConditionImpl*) * m_guard_conditions.size())); + static_cast(rmw_allocate(sizeof(GuardCondition*) * m_guard_conditions.size())); for (size_t i = 0; i < m_guard_conditions.size(); i++) { - guard_condition_data[i] = static_cast(m_guard_conditions.at(i)->data); + guard_condition_data[i] = static_cast(m_guard_conditions.at(i)->data); } m_guard_condition_array = std::make_unique(); @@ -148,10 +148,9 @@ class WaitSetTestContext /// @brief Constructs the array of subscriptions containing all subscriptions in the context. /// This is expected by rmw_wait(). rmw_subscriptions_t* subscriptions_array() { - auto subscriber_data = - static_cast(rmw_allocate(sizeof(SubscriberImpl*) * m_subscriptions.size())); + auto subscriber_data = static_cast(rmw_allocate(sizeof(Subscriber*) * m_subscriptions.size())); for (size_t i = 0; i < m_subscriptions.size(); i++) { - subscriber_data[i] = static_cast(m_subscriptions.at(i).subscriber->data); + subscriber_data[i] = static_cast(m_subscriptions.at(i).subscriber->data); } m_subscriptions_array = std::make_unique(); @@ -264,7 +263,7 @@ TEST_F(RmwWaitSetTest, can_wait_with_timeout) { } TEST_F(RmwWaitSetTest, can_be_triggered_by_guard_condition) { - using rmw::iox2::GuardConditionImpl; + using rmw::iox2::GuardCondition; // ===== Setup constexpr size_t NUM_GUARD_CONDITIONS{3}; @@ -303,7 +302,7 @@ TEST_F(RmwWaitSetTest, can_be_triggered_by_guard_condition) { } TEST_F(RmwWaitSetTest, can_be_triggered_by_message_sent_to_subscriber) { - using rmw::iox2::SubscriberImpl; + using rmw::iox2::Subscriber; using rmw_iceoryx2_cxx_test_msgs::msg::Defaults; // ===== Setup @@ -342,8 +341,8 @@ TEST_F(RmwWaitSetTest, can_be_triggered_by_message_sent_to_subscriber) { } TEST_F(RmwWaitSetTest, can_get_triggers_from_all_entity_types_in_single_wait) { - using rmw::iox2::GuardConditionImpl; - using rmw::iox2::SubscriberImpl; + using rmw::iox2::GuardCondition; + using rmw::iox2::Subscriber; using rmw_iceoryx2_cxx_test_msgs::msg::Defaults; // ===== Setup diff --git a/rmw_iceoryx2_cxx/test/testing/assertions.hpp b/rmw_iceoryx2_cxx/test/testing/assertions.hpp index 864129f..fb80048 100644 --- a/rmw_iceoryx2_cxx/test/testing/assertions.hpp +++ b/rmw_iceoryx2_cxx/test/testing/assertions.hpp @@ -11,7 +11,7 @@ #include "rmw/error_handling.h" #include "rmw/ret_types.h" -#include "rmw_iceoryx2_cxx/error_message.hpp" +#include "rmw_iceoryx2_cxx/impl/common/error_message.hpp" #define ASSERT_RMW_OK(expr) \ do { \