Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please review Moodle's security guidelines #7

Open
danmarsden opened this issue Mar 29, 2020 · 0 comments
Open

please review Moodle's security guidelines #7

danmarsden opened this issue Mar 29, 2020 · 0 comments

Comments

@danmarsden
Copy link

https://docs.moodle.org/dev/Security#Summary_of_the_guidelines

I can see some cases where you are using a !has_capability and then throwing an error with a hard-coded english langauge string. It might be better to replace those with require_capability calls.
make sure you review all your php code to see that require_login and a capabiltiy check are made before doing any other work - I saw a few that didn't appear to be checking a capability correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant