Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release not called in proper instance #8

Open
sp-rafael-lecina opened this issue Dec 11, 2019 · 3 comments
Open

Release not called in proper instance #8

sp-rafael-lecina opened this issue Dec 11, 2019 · 3 comments

Comments

@sp-rafael-lecina
Copy link

When trying to change the effect on an emmiter I've found that release is not called in proper variable

EffekseerForCocos2d-x/Players/Cocos2d-x_v3/Effekseer.cpp

Line 706 in 6dc9547

if (this->effect != nullptr) effect->release();

That line should be
if (this->effect != nullptr) this->effect->release();
Otherwise you are releasing the effect you are trying to set
@durswd
Copy link
Collaborator

durswd commented Dec 17, 2019

It is bug. Thank you for your report. I will fix it

durswd pushed a commit that referenced this issue Jan 1, 2020
Fix a bug that registered effect is released
cb23095 
#8
@durswd
Copy link
Collaborator

durswd commented Jan 1, 2020

I fixed

@sp-rafael-lecina
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@durswd @sp-rafael-lecina