fix: Restrict screen display timed out while video is playing #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerhabib26
requested review from
dixidroid,
farhan-arshad-dev and
HamzaIsrar12
|
The failed test cases will be fixed once #60 is merged |
omerhabib26
force-pushed
the
2U/omer/LEARNER-10249
branch
from
f2b3110 to
660b783
Compare
dixidroid
requested changes
Oct 16, 2024
| @@ -187,6 +189,7 @@ class VideoFullScreenFragment : Fragment(R.layout.fragment_video_full_screen) { | |||
| super.onPause() | |||
| exoPlayer?.removeListener(exoPlayerListener) | |||
| exoPlayer?.pause() | |||
| activity?.window?.clearFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON) | |||
There was a problem hiding this comment.
You added the flag in onCreate and clear it in onPause. Maybe it would be better to clear it in onDestroy? Or maybe better to add the flag in onResume...
There was a problem hiding this comment.
As only one activity is used, it is better to move the keepScreenOn at the view level IMO.
eg. playerView.keepScreenOn = true
PS: +1 with @dixidroid's comment to utilizing the onResume and onPause.
| @@ -277,6 +279,11 @@ class VideoUnitFragment : Fragment(R.layout.fragment_video_unit) { | |||
| } | |||
| } | |||
|
|
|||
| override fun onPause() { | |||
| super.onPause() | |||
| activity?.window?.clearFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON) | |||
farhan-arshad-dev
requested changes
Oct 17, 2024
| @@ -187,6 +189,7 @@ class VideoFullScreenFragment : Fragment(R.layout.fragment_video_full_screen) { | |||
| super.onPause() | |||
| exoPlayer?.removeListener(exoPlayerListener) | |||
| exoPlayer?.pause() | |||
| activity?.window?.clearFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON) | |||
There was a problem hiding this comment.
As only one activity is used, it is better to move the keepScreenOn at the view level IMO.
eg. playerView.keepScreenOn = true
PS: +1 with @dixidroid's comment to utilizing the onResume and onPause.
- Added flag to handle screen display timed out fix: LEARNER-10249
omerhabib26
force-pushed
the
2U/omer/LEARNER-10249
branch
from
660b783 to
0468215
Compare
dixidroid
approved these changes
Oct 22, 2024
farhan-arshad-dev
requested changes
Oct 23, 2024
course/src/main/java/org/openedx/course/presentation/unit/video/VideoFullScreenFragment.kt
Outdated
Show resolved
Hide resolved
farhan-arshad-dev
approved these changes
Oct 23, 2024
k1rill
approved these changes
Oct 23, 2024
farhan-arshad-dev
pushed a commit
that referenced
this pull request
Oct 31, 2024
- Added flag to handle screen display timed out - Moving the `keepScreenOn` flag to OnPause & OnResume due to instance lifecycle Fixes: LEARNER-10249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fix: LEARNER-10249