Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More components #3

Open
edvilme opened this issue Aug 8, 2021 · 9 comments
Open

More components #3

edvilme opened this issue Aug 8, 2021 · 9 comments
Labels
enhancement New feature or request up-for-grabs Can be addressed by open source contributors

Comments

@edvilme
Copy link
Owner

edvilme commented Aug 8, 2021

This is a completely new project. This can be a thread to annotate component ideas.

@edvilme edvilme added enhancement New feature or request up-for-grabs Can be addressed by open source contributors labels Aug 8, 2021
@AmanBhanse
Copy link

Hi, I am new to Open Source, but I like to contribute.
I am thinking about having rising letters animation. But I am finding it difficult to understand the flow in the code. How the render loop is working?
I understand the connectedCallback calls render but how it re-render the stuff??

if I do like this:

 connectedCallback(){
        this.render();
    }
    render(){
        console.log("Inside render");
    }

It calls render only once.

@edvilme
Copy link
Owner Author

edvilme commented Sep 5, 2021

Hi! Thanks a lot for your interest and support! Have a look at index.js.

All elements inherit from AnimatedElement. All the code for animation must be inside the animate() method.

I will try to add more comments and refactor to add some clarity. Thx for the feedback.

@edvilme
Copy link
Owner Author

edvilme commented Sep 6, 2021

Let me know if I can help in any way 😁

@AmanBhanse
Copy link

Hi! Thanks a lot for your interest and support! Have a look at index.js.

All elements inherit from AnimatedElement. All the code for animation must be inside the animate() method.

I will try to add more comments and refactor to add some clarity. Thx for the feedback.

Can you please enable the discussion for your repo , it would be better if we talk in discussion rather than in issues tab.

@edvilme
Copy link
Owner Author

edvilme commented Sep 12, 2021

Youre right, just enabled it. Will try to figure it out :D

@pranaybinju
Copy link
Contributor

Hi @edvilme
I would like to contribute to this project and have created animated Progress-bar component #20. Please do check it out and let me know your inputs or suggestions regarding it. Thanks!

@edvilme
Copy link
Owner Author

edvilme commented Oct 1, 2022

@pranaybinju hi. Thanks for the contribution. Will do some tests first thing in the morning. :D

@Sanga-byte29
Copy link

hi @edvilme i would like to contribute on this project
assign this issue to me

@pranaybinju
Copy link
Contributor

@pranaybinju hi. Thanks for the contribution. Will do some tests first thing in the morning. :D

Hi @edvilme , any updates on this ? Please do let me know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request up-for-grabs Can be addressed by open source contributors
Projects
None yet
Development

No branches or pull requests

4 participants