Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New TLS_CURVE25519 implementation breaks the library for TLS_V12 #115

Open
Wertzui123 opened this issue Jan 30, 2025 · 2 comments
Open

New TLS_CURVE25519 implementation breaks the library for TLS_V12 #115

Wertzui123 opened this issue Jan 30, 2025 · 2 comments

Comments

@Wertzui123
Copy link
Contributor

It looks like the new implementation for TLS_CURVE25519 (based on libtomcrypt and added in #111 / 8346fc2) breaks this library when using TLS 1.2.

I've been investigating this issue for an hour now and finally figured out that you can actually just reproduce it using the standard tlsclienthello.c example. Simply change TLS_V13 to TLS_V12 and you will get the following error message:

LTC_ARGCHK 'b != NULL' failure on line 26619 of file .\examples\../libtomcrypt.

A workaround for this seems to be to just disable curve 25519 using the NO_TLS_CURVE25519 macro, although I'm not sure if this breaks anything (as I don't even really know what curve 25519 is).

@eduardsui
Copy link
Owner

Hello!

I will take a look. Until fixed it is ok to disable it, it will use another curve.

Thank you,
Eduard

@Wertzui123
Copy link
Contributor Author

Alright, thank you!

Wertzui123 added a commit to aspl-lang/aspl that referenced this issue Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants