Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain certificates aren't valid due to missing struct fields #113

Open
Wertzui123 opened this issue Jan 25, 2025 · 1 comment
Open

Certain certificates aren't valid due to missing struct fields #113

Wertzui123 opened this issue Jan 25, 2025 · 1 comment

Comments

@Wertzui123
Copy link
Contributor

Firstly, sorry if this issue is written poorly - I just noticed the symptoms of this, but I don't (yet) understand TLS or the TLSe code base well enough to actually understand what's the problem here.

Anyway, so I've tried to reach github.com (or www.github.com, it doesn't matter) on port 443 using the tlsclienthello.c example. It doesn't work though. So I tried to investigate the issue, and it looks like there's a problem with the certificate validation.

tls_certificate_verify_signature returns 0 due to cert->sign_key etc. being zeroed; this seems like a bug to me.

tls_certificate_verify_signature is called by tls_certificate_chain_is_valid.

Am I doing anything wrong? Or is this a known issue already? Thank you!

@Wertzui123
Copy link
Contributor Author

This happens with TLS 1.2 as well as TLS 1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant