Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing shebang in bin/*.sh files #100

Open
EtaoinWu opened this issue Oct 15, 2024 · 0 comments
Open

Missing shebang in bin/*.sh files #100

EtaoinWu opened this issue Oct 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@EtaoinWu
Copy link

Describe the bug
All of the bin/*.sh files are missing shebang, so alpine cannot directly execute them.

To Reproduce
Steps to reproduce the behavior:

docker run -it --rm edasriyan/lottie-to-png lottie_to_png.sh

Expected result

usage: /usr/bin/lottie_to_png.sh [--help] [--output OUTPUT] [--height HEIGHT] [--width WIDTH] [--threads THREADS] [--fps FPS] [-
-quality QUALITY] path                                                                                                          
                                                                                                                                
Lottie animations (.json) and Telegram stickers for Telegram (*.tgs) to animated .png converter                                 
                                                                                                                                
Positional arguments:                                                                                                           
 path              Path to .json or .tgs file to convert                                                                        
                                                                                                                                
Optional arguments:                                                                                                             
 -h, --help        shows this help message and exits                                                                            
 -v, --version     prints version information and exits                                                                         
 --output OUTPUT   Output file path                                                                                             
 --height HEIGHT   Output image height. Default: 512                                                                            
 --width WIDTH     Output image width. Default: 512                                                                             
 --fps FPS         Output frame rate. Default: 60                                                                               
 --threads THREADS Number of threads to use. Default: number of CPUs                                                            
 --quality QUALITY Output quality. Default: 90                                                                                  

Actual result
see below.

Console copy-paste
Please copy-paste command run and program output

[root@machine dir]# docker run -it --rm edasriyan/lottie-to-png lottie_to_png.sh
exec /usr/bin/lottie_to_png.sh: exec format error

Desktop (please complete the following information):

  • OS: AlmaLinux 9.4, but this shouldn't matter
  • Arch: x86_64

Potential fix
Add #!/bin/sh to every bin/*.sh file.

@EtaoinWu EtaoinWu added the bug Something isn't working label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant