-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Dockerfile #96
Comments
Hi František, Using the official Docker Images will not (always) be possible. The Payara Docker Image, for example, allows you to run a WAR file, but the MicroProfile Starter is built around creating JAR files. We can create a DockerFile which starts from a Java-based image but is this useful? |
Hello Rudy, good point, however I think it can be useful even in case of pure Java based image. Such Dockerfile can be showcase of "best practices" how to bundle microprofile apps with proper JVM flags (important for Java 8). Just curious support of WARs is not planned? |
Most people find that MicroServices needs to be run from executable JAR files. They find that WARs are to tight linked to the 'old school' Application servers. (opinion of some, maybe not the truth :) ) MicroProfile Starter generates for most implementations a WAR file and afterward, it is packaged within an executable JAR. |
Can you give a list of JVM parameters which you want to see? Because there exist also a lot of different opinions about that. Then we can get the discussion started. |
I was thinking along the similar line. I think it is a good idea to provide a docker image for each runtime since we are building cloud-native microservices. |
Yes that was my point, that with WARs docker images can be pretty efficient. Regarding JVM flags for java 8 (from update 131) at least two are needed From java 10+ it should be set correctly by default without any flags. There is also possibility to fine grain heap allocation with |
Hi, i think, it‘s a good idea to have also a kubernetes configuration optional. For my company, it’s very important to have small war files (kB) to shipping with docker... |
Hi,
It would be great if there is option to generate Dockerfile for selected application server based on official images.
Basically it would copy war to deployment directory and copy generated server configuration.
The text was updated successfully, but these errors were encountered: