Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long files can cause freezes #275

Closed
mickaelistria opened this issue Apr 6, 2021 · 2 comments
Closed

Long files can cause freezes #275

mickaelistria opened this issue Apr 6, 2021 · 2 comments

Comments

@mickaelistria
Copy link
Contributor

See eclipse-wildwebdeveloper/wildwebdeveloper#667
When frozen, the UI Freeze monitoring reports the following stack traces:

Stack Trace
	at org.eclipse.tm4e.core.internal.css.CSSConditionalSelector.nbMatch(CSSConditionalSelector.java:61)
	at org.eclipse.tm4e.core.theme.css.CSSParser.getBestStyle(CSSParser.java:73)
	at org.eclipse.tm4e.ui.themes.css.CSSTokenProvider.getToken(CSSTokenProvider.java:71)
	at org.eclipse.tm4e.ui.themes.Theme.getToken(Theme.java:83)
	at org.eclipse.tm4e.ui.text.TMPresentationReconciler.toToken(TMPresentationReconciler.java:614)
	at org.eclipse.tm4e.ui.text.TMPresentationReconciler.colorize(TMPresentationReconciler.java:560)
	at org.eclipse.tm4e.ui.text.TMPresentationReconciler$InternalListener.textChanged(TMPresentationReconciler.java:309)
	at org.eclipse.jface.text.TextViewer.updateTextListeners(TextViewer.java:2709)
	at org.eclipse.jface.text.TextViewer.invalidateTextPresentation(TextViewer.java:3353)

or

Stack Trace
	at org.eclipse.tm4e.core.internal.css.CSSAndCondition.nbMatch(CSSAndCondition.java:32)
	at org.eclipse.tm4e.core.internal.css.CSSConditionalSelector.nbMatch(CSSConditionalSelector.java:62)
	at org.eclipse.tm4e.core.theme.css.CSSParser.getBestStyle(CSSParser.java:73)
	at org.eclipse.tm4e.ui.themes.css.CSSTokenProvider.getToken(CSSTokenProvider.java:71)
	at org.eclipse.tm4e.ui.themes.Theme.getToken(Theme.java:83)
	at org.eclipse.tm4e.ui.text.TMPresentationReconciler.toToken(TMPresentationReconciler.java:614)
	at org.eclipse.tm4e.ui.text.TMPresentationReconciler.colorize(TMPresentationReconciler.java:560)
	at org.eclipse.tm4e.ui.text.TMPresentationReconciler$InternalListener.textChanged(TMPresentationReconciler.java:309)
	at org.eclipse.jface.text.TextViewer.updateTextListeners(TextViewer.java:2709)
	at org.eclipse.jface.text.TextViewer.invalidateTextPresentation(TextViewer.java:3353)

and others, all mentioning TMPresentationReconciler.colorize()

@sebthom
Copy link
Member

sebthom commented May 25, 2023

I cannot reproduce this with the latest TM4E release. I can see how the file gets incrementally colorized without the UI freezing.
I tested it with the mapper_v3.js file attached to the referenced issue.

@mickaelistria
Copy link
Contributor Author

I don't think I got annoyed by this issue for a while, so I'm fine closing this old and probably outdated report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants