Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code mining sometimes leaves some empty lines #1959

Open
rhoehener opened this issue Jun 12, 2024 · 5 comments
Open

Code mining sometimes leaves some empty lines #1959

rhoehener opened this issue Jun 12, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@rhoehener
Copy link

I was asked to report this here from eclipse-wildwebdeveloper/wildwebdeveloper#1603

image

Reproduce: Eclipse 2024-03, create new xml file, open with both wtp and wwd xml editors. Enable XML CodeLens:
image

@rhoehener rhoehener added the bug Something isn't working label Jun 12, 2024
@rhoehener
Copy link
Author

It appears that the WWD setting also affects the WTP editor.

@iloveeclipse
Copy link
Member

It appears that the WWD setting also affects the WTP editor.

Neither one belongs to the platform. Please open a bug for the appropriate project.

@mickaelistria
Copy link
Contributor

I'm reopening. The issue was initially posted to wild web developer, but still a part of the issue belongs to Platform: there should be no empty line.

@mickaelistria mickaelistria changed the title [xml editor wtp/wwd]: artificial empty lines without line number Code mining sometimes leaves some empty lines Jun 12, 2024
@iloveeclipse
Copy link
Member

there should be no empty line.

Isn't that added by the "CodeLens" which isn't part of the platform?
Please explain why do you think the problem belongs to platform.

@mickaelistria
Copy link
Contributor

The empty line is most likely garbage of the code mining renderer. I'll double check but I don't think the XML language server sends any codelens between line 1 and 2, so the empty line here seems wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants