Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-Tools] Ignore test src folders by default #1496

Open
HannesWell opened this issue Nov 27, 2024 · 3 comments
Open

[API-Tools] Ignore test src folders by default #1496

HannesWell opened this issue Nov 27, 2024 · 3 comments

Comments

@HannesWell
Copy link
Member

The content of test-src folder usually does not contribute to a bundle's API since it's usually not included in the built artifact.
Therefore API-Tools should simply ignore the content of test-src folders.

In eclipse-platform/eclipse.platform.swt#1614 this caused problems because the content of src-folders was considered as new classes.

@laeubi
Copy link
Contributor

laeubi commented Dec 29, 2024

@HannesWell even after reading the referenced issue twice I don't understand why this is caused by test-src folders...

@laeubi
Copy link
Contributor

laeubi commented Dec 29, 2024

I especially found org.eclipse.pde.api.tools.internal.util.Util.isTest(IType) that already seem to check if a type is from a test folder.

@HannesWell
Copy link
Member Author

@HannesWell even after reading the referenced issue twice I don't understand why this is caused by test-src folders...

If a Plug-in project as has a main src and a test-src, the content of the test-src folder is (of course) not contained in the built/published artifact and is therefore not present in the baseline.
And then API tools considers each public test-class in that the test-src as new API.

I especially found org.eclipse.pde.api.tools.internal.util.Util.isTest(IType) that already seem to check if a type is from a test folder.

Maybe that test does not work in case of the scenario of SWT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants