Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module-info to the modules #830

Open
Thihup opened this issue May 2, 2024 · 4 comments · Fixed by #843
Open

Add module-info to the modules #830

Thihup opened this issue May 2, 2024 · 4 comments · Fixed by #843

Comments

@Thihup
Copy link
Contributor

Thihup commented May 2, 2024

Adding a module-info to the modules will make the life easier for whom wants to create a JLinked runtime including only the necessary modules. Most LSP servers are standalone programs, so it makes sense to create a LSP server using a JLinked runtime.

@nixel2007
Copy link
Contributor

Totally agree. BSL Language Server is packaged via jpackage and runtime image is quite huge.

@jonahgraham
Copy link
Contributor

I will be happy to review a PR that provides the needed info. Please tag me in such a PR.

Thihup added a commit to Thihup/lsp4j that referenced this issue Jun 10, 2024
Thihup added a commit to Thihup/lsp4j that referenced this issue Jun 10, 2024
@jonahgraham jonahgraham linked a pull request Jun 10, 2024 that will close this issue
@jonahgraham jonahgraham added this to the 0.24.0 milestone Aug 20, 2024
@jonahgraham jonahgraham reopened this Nov 26, 2024
@jonahgraham
Copy link
Contributor

@Thihup this seems to have caused a significant regression. Please see #855 - I am hoping we can resolve the issue without needing to revert it. Please share your thoughts.

@cdietrich
Copy link
Contributor

maybe there is something that makes buildship configure the module thing correctly

@jonahgraham jonahgraham mentioned this issue Jan 8, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants