Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devworkspace-generator should not use resources published by plugin registry #23187

Closed
svor opened this issue Oct 9, 2024 · 0 comments
Closed
Assignees
Labels
area/devworkspace-generator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che

Comments

@svor
Copy link
Contributor

svor commented Oct 9, 2024

Is your task related to a problem? Please describe

devworkspace-generator uses resources published by plugin registry: https://github.com/devfile/devworkspace-generator/blob/main/src/main.ts#L60. It happens when ediotrPath or editorContent is not provided as a parameter.

Since che-plugin registry is going to be deprecated and all editors definitions were moved into che-operator, devworkspace generaor needs to be adapted to these changes.

Describe the solution you'd like

Use editors definitions from che-operator repo if editorPath or editorContent is not set

Describe alternatives you've considered

At least one of editorPath or editorContent parameter should be set when executing the generator

Additional context

No response

@svor svor added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che area/devworkspace-generator labels Oct 9, 2024
@svor svor self-assigned this Oct 9, 2024
@svor svor moved this to 📋 Backlog in Eclipse Che Team A Backlog Oct 9, 2024
@ibuziuk ibuziuk moved this from 📋 Backlog to 📅 Planned in Eclipse Che Team A Backlog Oct 9, 2024
@svor svor moved this from 📅 Planned to 🚧 In Progress in Eclipse Che Team A Backlog Oct 14, 2024
@svor svor moved this from 🚧 In Progress to Ready for Review in Eclipse Che Team A Backlog Oct 16, 2024
@svor svor moved this from Ready for Review to ✅ Done in Eclipse Che Team A Backlog Oct 22, 2024
@svor svor closed this as completed Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devworkspace-generator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant