Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetBrains IDE-based CDE should not depend on Node.js presence in a user's container #23174

Closed
azatsarynnyy opened this issue Oct 1, 2024 · 1 comment
Assignees
Labels
area/editors kind/enhancement A feature request - must adhere to the feature request template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. severity/P1 Has a major impact to usage or development of the system.

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Oct 1, 2024

Is your task related to a problem? Please describe

When the user starts a workspace with a JetBrains IDE from the Dashboard,
they need to make sure Node.js is present in a tools container.

Node.js is required to serve the stub web page that the Dashboard forwards to once the CDE is started:

image

This page also serves as an editor's main endpoint.

This is not a problem when starting a CDE for JS development, because the tools container always includes Node.js.
But when starting a CDE for Java development (e.g. Spring Boot stack) there's a low chance Node.js is present in a tools container.

In this case, the Dashboard forwards to itself continuously when trying to open an editor page for such a CDE:

Screen.Recording.2024-10-01.at.14.00.31.mov

Describe the solution you'd like

The editor-injector init-container should bring the Node.js binaries with all the required libraries,
and copy it to the tools container together with the editor binaries.

Describe alternatives you've considered

The user always can open CDE from the JetBrains Gateway application:

image

As it doesn't depend on Che Dashboard.

Additional context

No response

@azatsarynnyy azatsarynnyy added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. area/editors labels Oct 1, 2024
@azatsarynnyy azatsarynnyy self-assigned this Oct 1, 2024
@ibuziuk ibuziuk added the severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. label Oct 1, 2024
@ibuziuk ibuziuk moved this to Unplanned in Eclipse Che Team B Backlog Oct 1, 2024
@azatsarynnyy
Copy link
Member Author

azatsarynnyy commented Oct 7, 2024

Fixed by che-incubator/jetbrains-ide-dev-server@d6489e7 and che-incubator/jetbrains-ide-dev-server@f62b3e3

Now,

image
with
image
work as well, as
image
with
image

@github-project-automation github-project-automation bot moved this from Unplanned to ✅ Done in Eclipse Che Team B Backlog Oct 7, 2024
@azatsarynnyy azatsarynnyy changed the title JetBrains IDE-based CDE should no depend on Node.js presense in a tools container JetBrains IDE-based CDE should not depend on Node.js presense in a user's container Oct 7, 2024
@dkwon17 dkwon17 changed the title JetBrains IDE-based CDE should not depend on Node.js presense in a user's container JetBrains IDE-based CDE should not depend on Node.js presence in a user's container Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editors kind/enhancement A feature request - must adhere to the feature request template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. severity/P1 Has a major impact to usage or development of the system.
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants