Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Untrusted Repository modal reappears when the workspace starts #23097

Closed
akurinnoy opened this issue Aug 16, 2024 · 1 comment · Fixed by eclipse-che/che-dashboard#1172
Closed

The Untrusted Repository modal reappears when the workspace starts #23097

akurinnoy opened this issue Aug 16, 2024 · 1 comment · Fixed by eclipse-che/che-dashboard#1172
Assignees
@akurinnoy
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@akurinnoy
Copy link
Contributor

Describe the bug

The Untrusted Repository modal reappears when the workspace starts.

Che version

7.90@latest

Steps to reproduce

  1. Create a new workspace from an untrusted repository URL:
    1.1. If necessary, remove the trusted-sources filed from the workspace-preferences-configmap);
    1.2. Paste the repository URL into the Import from Git field and click Create & Open;
    1.3. Confirm that you trust the authors of the repository;
  2. While the workspace is starting up, switch between the tabs on the page: Progress -> Logs -> Events;
  3. The Untrusted Repository modal should appear at some moment.

Expected behavior

Once confirmed, the Untrusted Repository modal should not be displayed for the same repository URL.

Runtime

minikube

Screenshots

Screen.Recording.2024-08-16.at.18.15.35.mov

Installation method

chectl/next

Environment

macOS

Eclipse Che Logs

No response

Additional context

No response
@akurinnoy akurinnoy added kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. area/dashboard labels Aug 16, 2024
@akurinnoy akurinnoy moved this to 📋 Backlog in Eclipse Che Team A Backlog Aug 16, 2024
@ibuziuk
Copy link
Member

ibuziuk commented Aug 16, 2024

👍 I believe we will need a cherry-pick to 7.90.x

@ibuziuk ibuziuk moved this from 📋 Backlog to Unplanned Tasks in Eclipse Che Team A Backlog Aug 19, 2024
@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Aug 19, 2024
@akurinnoy akurinnoy moved this from Unplanned Tasks to 🚧 In Progress in Eclipse Che Team A Backlog Aug 20, 2024
@akurinnoy akurinnoy mentioned this issue Aug 21, 2024
Merged
@akurinnoy akurinnoy moved this from 🚧 In Progress to Ready for Review in Eclipse Che Team A Backlog Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akurinnoy akurinnoy

Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
Eclipse Che Team A Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not show modal for trusted repositories eclipse-che/che-dashboard
2 participants
@ibuziuk @akurinnoy