Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace start page goes to cyclic reload if refresh token mode is applied #23028

Closed
vinokurig opened this issue Jul 2, 2024 · 4 comments · Fixed by eclipse-che/che-server#699
Closed

Workspace start page goes to cyclic reload if refresh token mode is applied #23028

vinokurig opened this issue Jul 2, 2024 · 4 comments · Fixed by eclipse-che/che-server#699
Assignees
@vinokurig
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@vinokurig
Copy link
Contributor

Describe the bug

Workspace start dashboard page reloads cyclically, if refresh token mode is applied. A new personal access token is created on each page restart.

Che version

7.88@latest

Steps to reproduce

  1. Configure GitHub oauth
  2. Apply refresh token mode
  3. Start a workspace from a GitHub repository with a devfile.

Expected behavior

Workspace starts after only one page refresh.

Runtime

OpenShift

Screenshots

No response

Installation method

chectl/next

Environment

macOS

Eclipse Che Logs

No response

Additional context

No response
@vinokurig vinokurig added kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. labels Jul 2, 2024
@vinokurig vinokurig self-assigned this Jul 2, 2024
@ibuziuk ibuziuk moved this to Unplanned Tasks in Eclipse Che Team A Backlog Jul 2, 2024
@vinokurig
Copy link
Contributor Author

Token expiration period for supported git porviders:

Provider name Expiration time
GitHub SAAS (github.com) no expiration
GitHub Enterprise Server no expiration
GitLab SAAS (gitlab.com) 2 hours
GitLab Server 2 hours
Bitbucket SAAS (bitbucket.org) 2 hours
Bitbucket Server 90 days
Microsoft Azure Devops 1 hour

@ibuziuk
Copy link
Member

ibuziuk commented Jul 8, 2024

@vinokurig thanks for investigation, we can skip GitHub in this case and refresh tokens every time for other providers if the property is enabled - https://eclipse.dev/che/docs/stable/administration-guide/configuring-oauth-for-git-providers/ (we also need to mention that in the docs).

@vinokurig
Copy link
Contributor Author

The issue is relevant for Azure devops as well.

@vinokurig vinokurig mentioned this issue Jul 10, 2024
Merged
9 tasks
@vinokurig vinokurig moved this from Unplanned Tasks to Ready for Review in Eclipse Che Team A Backlog Jul 11, 2024
@dkwon17 dkwon17 added severity/P1 Has a major impact to usage or development of the system. and removed severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. labels Jul 18, 2024
@ibuziuk
Copy link
Member

ibuziuk commented Jul 18, 2024

Moving to P1 to unblock the 7.89.0 release

@vinokurig vinokurig moved this from Ready for Review to ✅ Done in Eclipse Che Team A Backlog Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
Eclipse Che Team A Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip refresh GitHub tokens, override refresh Azure DevOps token request eclipse-che/che-server
3 participants
@ibuziuk @vinokurig @dkwon17