Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate previous tokens if refresh token mode is enabled #23027

Closed
vinokurig opened this issue Jul 1, 2024 · 0 comments · Fixed by eclipse-che/che-server#703
Closed

Invalidate previous tokens if refresh token mode is enabled #23027

vinokurig opened this issue Jul 1, 2024 · 0 comments · Fixed by eclipse-che/che-server#703
Assignees
@vinokurig
Labels
area/che-server kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@vinokurig
Copy link
Contributor

vinokurig commented Jul 1, 2024 •
edited
Loading

Is your enhancement related to a problem? Please describe

If the refresh token mode is enabled, we generate a new token on each workspace start / restart, but we do nothing with previous tokens. This may cause to a long list of tokens in the user preferences page.

Describe the solution you'd like

When generating a new token on top of the existed one, delete the old token, even if it is not expired.

Describe alternatives you've considered

No response

Additional context

see #23005
@vinokurig vinokurig added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 1, 2024
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 1, 2024
@ibuziuk ibuziuk added the severity/P1 Has a major impact to usage or development of the system. label Jul 1, 2024
@ibuziuk ibuziuk moved this to Unplanned Tasks in Eclipse Che Team A Backlog Jul 1, 2024
@vinokurig vinokurig self-assigned this Jul 1, 2024
@ibuziuk ibuziuk removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 1, 2024
@vinokurig vinokurig moved this from Unplanned Tasks to 🚧 In Progress in Eclipse Che Team A Backlog Jul 17, 2024
@vinokurig vinokurig mentioned this issue Jul 18, 2024
Merged
9 tasks
@vinokurig vinokurig moved this from 🚧 In Progress to Ready for Review in Eclipse Che Team A Backlog Jul 19, 2024
@vinokurig vinokurig moved this from Ready for Review to ✅ Done in Eclipse Che Team A Backlog Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
area/che-server kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
Eclipse Che Team A Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundan PATs on refresh mode eclipse-che/che-server
3 participants
@ibuziuk @vinokurig @che-bot