From 2d1002795a94d3feab60fb2c542afae0238f60e3 Mon Sep 17 00:00:00 2001 From: Maksym Musiienko Date: Thu, 31 Oct 2024 19:57:43 +0200 Subject: [PATCH] Add compile and lint verifications before testing (#23224) * add compile and lint verifications before testing --- .github/workflows/pr-check.yml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 7eea4b6860b..204961bf4bb 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -30,7 +30,9 @@ env: jobs: pr-check: runs-on: ubuntu-22.04 - + defaults: + run: + working-directory: tests/e2e steps: - name: Git checkout uses: actions/checkout@v2 @@ -48,6 +50,15 @@ jobs: with: node-version: '16' + - name: Check compilation errors + run: | + npm ci + npm run tsc + + - name: Check lint errors + run: | + npm run lint + - name: Start minikube id: run-minikube uses: che-incubator/setup-minikube-action@next @@ -92,8 +103,6 @@ jobs: - name: Run Empty Workspace API test run: | - cd tests/e2e - npm ci export TS_PLATFORM=kubernetes && export TS_API_TEST_KUBERNETES_COMMAND_LINE_TOOL=kubectl && export TS_SELENIUM_VALUE_OPENSHIFT_OAUTH=false && @@ -109,7 +118,6 @@ jobs: run: | # for saving disk space we can remove the assembly folder because it is legacy code rm -rf assembly - cd tests/e2e docker build -t quay.io/eclipse/che-e2e:"${{ env.pr_number }}" -f build/dockerfiles/Dockerfile . # we have already ran API test, built test image and do not need e2e test-code, remove for saving disk space