Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--new-pr with existing file leads to error even if not modified #4751

Open
Flamefire opened this issue Jan 23, 2025 · 0 comments · May be fixed by #4753
Open

--new-pr with existing file leads to error even if not modified #4751

Flamefire opened this issue Jan 23, 2025 · 0 comments · May be fixed by #4753
Labels
bug report
Milestone
4.x

Comments

@Flamefire
Copy link
Contributor

I tried to do a eb --new-pr * to add new files but it failed with

ERROR: A meaningful commit message must be specified via --pr-commit-msg when modifying/deleting files or targeting the framework repo.
Modified: lxml-5.3.0-GCCcore-13.3.0.eb

Something must be wrong in the detection
@boegel boegel added this to the 4.x milestone Jan 29, 2025
Flamefire added a commit to Flamefire/easybuild-framework that referenced this issue Feb 4, 2025
@Flamefire
Ignore unmodified files when using --new-pr or --update_pr
426f0a9 
When including an unmodified EasyConfig with `--new-pr` an error is
shown that a commit message is required because this EC is modified
which is not the case.

Adjust the `copy_*` functions to ignore any unmodified file.
This especially ommits them in the `file_info` struct returned that is
then used to determine commit message/title etc.

Fixes easybuilders#4751
@Flamefire Flamefire linked a pull request Feb 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report
Projects
None yet
Milestone
4.x
Development

Successfully merging a pull request may close this issue.

Ignore unmodified files when using --new-pr or --update_pr Flamefire/easybuild-framework
2 participants
@Flamefire @boegel