Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: okhttp-based jvm implementation #10

Open
thevery opened this issue Jul 24, 2018 · 4 comments
Open

Feature request: okhttp-based jvm implementation #10

thevery opened this issue Jul 24, 2018 · 4 comments

Comments

@thevery
Copy link

thevery commented Jul 24, 2018

Implementation itself is pretty trivial, but the most important part is option to pass actual httpclient instance.

@e5l
Copy link
Owner

e5l commented Jul 25, 2018

Hi, @thevery.
Just for my interest :), what kind of stuff you missed in the ktor client to use it on android?

@thevery
Copy link
Author

thevery commented Jul 25, 2018

We use okhttp for interceptors (user-agent and logs), timeouts, retrofit, stetho and even custom dns resolving. But the main reason for okhttp is easy migration from exisrit kotlin android code to common code.
Another thing I miss in common http client is blocking calls, but this is a subject of another feature request.

@e5l
Copy link
Owner

e5l commented Jul 25, 2018

What you mean by blocking?

@thevery
Copy link
Author

thevery commented Jul 25, 2018

#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants