Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[log] Rename log package to dlog #120

Open
at15 opened this issue Jan 19, 2020 · 0 comments
Open

[log] Rename log package to dlog #120

at15 opened this issue Jan 19, 2020 · 0 comments
Assignees
Milestone

Comments

@at15
Copy link
Member

at15 commented Jan 19, 2020

The main reason is gommon/log does NOT have package level methods to log with default config.
So most time in pkg.go I have the following code

import (
    dlog "github.com/dyweb/gommon/log"
)

var logReg = dlog.NewRegistry()
var log = logReg.Logger()

To avoid the rename during import, we can just rename the package because log is used more often, while the logger of gommon/log is a drop in replacement for many logging libraries, the library itself is not. This is also why we use errors instead of derrors. The d prefix from dyweb

It will break all the application/dependencies that depend on it, but AFIK there is no third party library or application using gommon/log

@at15 at15 added this to the 0.0.15 milestone Jan 19, 2020
@at15 at15 self-assigned this Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant