-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with default expiry time #43
Comments
@alanshaw much betterer! 👍 |
PR out #78 |
Gents, my reading of |
I think we solved it from an expiration point of view by adding the '7d' option. What I see now is that we have travis-ci not happy about that change and I'm not sure how to debug it. |
PR #79 out for test fix. green build this time :) |
@emersonmellado thanks again for making time to fix this! 👍 |
The intention is to expire in 7 days, but the code doesn't provide a number thats 7 days ahead of now...far from it!
https://github.com/dwyl/learn-json-web-tokens/blob/master/example/lib/helpers.js#L39
I used this instead:
The text was updated successfully, but these errors were encountered: