transaction hash labels (just cow protocol for now) #2810
andrewhong5297
started this conversation in
Sector: Labels
Replies: 3 comments 4 replies
-
That's fine by me. I would appreciate it if we could merge all my current open PRs and move them together instead of having to change every single PR now. |
Beta Was this translation helpful? Give feedback.
2 replies
-
fyi we are moving things around so that |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We're looking to consolidate all kinds of labels (i.e. models that use the
label
tag) under thelabels
folder. Using directories instead of tags to organize will make navigation and maintenance easier long term.This means moving the tx hash labels in cowswap in as well, however these should not be appended to the address labels table.
My only feedback is that
category
should likely beprotocol
, thelabel_type
should beevent_type
instead (like “swap, hack, payment, governance, etc”), and the currentcategory
should be moved tomodel_name
.Thoughts @gentrexha @0xRobin @jeff-dude ?
Beta Was this translation helpful? Give feedback.
All reactions