From 67be651b7eb6db235184c96cc09904951b2b863d Mon Sep 17 00:00:00 2001 From: Sam Ansmink Date: Sat, 12 Oct 2024 23:26:38 +0200 Subject: [PATCH 1/2] fix space cleanup step --- .github/workflows/_extension_distribution.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/_extension_distribution.yml b/.github/workflows/_extension_distribution.yml index 1cad557..6dba8e0 100644 --- a/.github/workflows/_extension_distribution.yml +++ b/.github/workflows/_extension_distribution.yml @@ -207,6 +207,7 @@ jobs: steps: - name: Free up some unused space + continue-on-error: true run: | docker rmi $(docker images -a -q) From d2375d5b3356ea6a6178071cc29f6d91d71321ed Mon Sep 17 00:00:00 2001 From: Sam Ansmink Date: Mon, 14 Oct 2024 10:53:37 +0200 Subject: [PATCH 2/2] add byteorder for old python versions --- scripts/append_extension_metadata.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/append_extension_metadata.py b/scripts/append_extension_metadata.py index 8540b3d..7ea59a0 100644 --- a/scripts/append_extension_metadata.py +++ b/scripts/append_extension_metadata.py @@ -5,19 +5,19 @@ def start_signature(): # This is needed so that Wasm binaries are valid encoded_string = ''.encode('ascii') # 0 for custom section - encoded_string += int(0).to_bytes(1) + encoded_string += int(0).to_bytes(1, byteorder='big') # 213 in hex = 531 in decimal, total lenght of what follows (1 + 16 + 2 + 8x32 + 256) # [1(continuation) + 0010011(payload) = \x93 -> 147, 0(continuation) + 10(payload) = \x04 -> 4] - encoded_string += int(147).to_bytes(1) - encoded_string += int(4).to_bytes(1) + encoded_string += int(147).to_bytes(1, byteorder='big') + encoded_string += int(4).to_bytes(1, byteorder='big') # 10 in hex = 16 in decimal, lenght of name, 1 byte - encoded_string += int(16).to_bytes(1) + encoded_string += int(16).to_bytes(1, byteorder='big') # the name of the WebAssembly custom section, 16 bytes encoded_string += b'duckdb_signature' # 1000 in hex, 512 in decimal # [1(continuation) + 0000000(payload) = -> 128, 0(continuation) + 100(payload) -> 4], - encoded_string += int(128).to_bytes(1) - encoded_string += int(4).to_bytes(1) + encoded_string += int(128).to_bytes(1, byteorder='big') + encoded_string += int(4).to_bytes(1, byteorder='big') return encoded_string def padded_byte_string(input):