-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include major versions of contrib modules which are marked unsupported #29
Comments
Could you provide an example project? |
Example: easy_breadcrumb. I couldn't find the info about supported branches in drupal.org JSON API. I think we have to use Update Status XML. https://updates.drupal.org/release-history/easy_breadcrumb/current => supported_branches |
You can also use Admin Toolbar as an example, 3.0.3 is reported as unsupported in Drupal's Updates UI (3.1.0 is available), but currently this tool does not complain about it. |
IMO unsupported is a different and less grave situation than actively insecure status. I dont see enough value in treating them the same. IMO this is wont fix for this project. |
Drupal security advisories appear to treat them the same. And the name of this project is pretty closely tied to those IMO 😉 |
To make this even more complicated, we're talking about two different definitions of "unsupported." The recent slew of advisories marks entire projects "unsupported," and this is I think surfaced in the API as something like This is different from what is proposed here, which is for branches of opted-in modules to be marked unsupported. For instance, Simple OAuth is removing support from 8.x-4.x at the end of February, but 5.2.x is supported. |
Ahh yes you're right, and there's already an open issue #7 for that...sorry for the noise. |
I disagree, though not strongly. I think it would be a "secure" outcome if we could be confident that security releases would flag unsupported branches when they are released, but I am not sure/don't think this is the case. Take for example Simple OAuth module, which I co-maintain: We are planning to mark unsupported 8.x-4.x and 5.0.x in the next few months. It's highly likely that many users will not upgrade. Let's say there's a security release on 5.2.x; we would not backport the security patch to prior (not unsupported) versions. I'd need to validate what the releases API would show, then; would it mark insecure |
If anybody is looking for a solution for this particular problem, let me promote my tool that collects all unsupported packages from Drupal.org every day. https://packagist.org/packages/mxr576/ddqg#dev-no-no-unsupported-versions It can be also combined with |
Let's say a contrib module moves from having active support of both a
1.x
and2.x
branch, but1.x
reaches EOL. Can we include a constraint for^1
? That would allow tools likedrush sec
to flag these versions as unsupported, even if there is not a corresponding security issue/release prompting its inclusion.Similar in spirit to #7 but only for branches.
The text was updated successfully, but these errors were encountered: