You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit. If you want to read more about LTO, I can recommend starting from this Rustc documentation.
I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where in addition to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application with cargo install or building the Release Docker image, will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile.
Basically, it can be enabled with the following lines:
[profile.release]
lto = true
I have made quick tests (Fedora 41) by adding lto = true to the Release profile. The binary size reduction is from 11 Mib to 8.7 Mib.
Additionally, I performed LTO tests for the Crows tool since it was mentioned in the README file. I would be glad if you enable LTO there too since it also brings benefits (also with lto = true to the Release profile):
crows binary size reduced from 18 Mib to 13 Mib (the same for crows-worker)
I didn't want to create a separate issue for Crows since it can be a bit annoying (but I can do it if you want :)
Thank you.
The text was updated successfully, but these errors were encountered:
Hi!
I noticed that in the
Cargo.toml
file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit. If you want to read more about LTO, I can recommend starting from this Rustc documentation.I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional
dist
orrelease-lto
profile where in addition to regularrelease
optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application withcargo install
or building the Release Docker image, will get the LTO-optimized version "automatically". E.g., checkcargo-outdated
Release profile.Basically, it can be enabled with the following lines:
I have made quick tests (Fedora 41) by adding
lto = true
to the Release profile. The binary size reduction is from 11 Mib to 8.7 Mib.Additionally, I performed LTO tests for the Crows tool since it was mentioned in the README file. I would be glad if you enable LTO there too since it also brings benefits (also with
lto = true
to the Release profile):crows
binary size reduced from 18 Mib to 13 Mib (the same forcrows-worker
)I didn't want to create a separate issue for Crows since it can be a bit annoying (but I can do it if you want :)
Thank you.
The text was updated successfully, but these errors were encountered: