You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In WebService::Braintree::Customer, both create() and find() are supposed to return a Result object with the customer() method available, according to the POD. create() does this as expected, but find() returns the actual customer object instead.
Looking through the various Gateway modules, most of the find() methods return a Result object, but three don't:
CustomerGateway
MerchantAccountGateway
SubscriptionGateway
Changing these three to match the rest will break existing code, but that probably makes more sense than having some modules work one way and some another (which is how I found the inconsistency). The fix is to remove the ->customer or equivalent call after _make_request in each module's find() method.
The text was updated successfully, but these errors were encountered:
In WebService::Braintree::Customer, both
create()
andfind()
are supposed to return a Result object with thecustomer()
method available, according to the POD.create()
does this as expected, butfind()
returns the actual customer object instead.Looking through the various Gateway modules, most of the
find()
methods return a Result object, but three don't:Changing these three to match the rest will break existing code, but that probably makes more sense than having some modules work one way and some another (which is how I found the inconsistency). The fix is to remove the
->customer
or equivalent call after_make_request
in each module'sfind()
method.The text was updated successfully, but these errors were encountered: