Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope the product EOL date to repos #1553

Open
mthalman opened this issue Jan 16, 2025 · 0 comments
Open

Scope the product EOL date to repos #1553

mthalman opened this issue Jan 16, 2025 · 0 comments

Comments

@mthalman
Copy link
Member

mthalman commented Jan 16, 2025

The logic which computes the EOL annotations that need to be applied has an option for querying the .NET releases JSON file to determine the EOL dates of .NET versions:

if (Options.AnnotateEolProducts)
{
// Annotate images for EOL products in new image info
// Only do so for those digests that actually exist in the registry (they may have been cleaned up
// because they are EOL).
IEnumerable<EolDigestData> eolDigests =
newImageArtifactDetails.Repos
.SelectMany(repo =>
repo.Images
.SelectMany(image => GetProductEolDigests(image, productEolDates)))
.Where(digestData => registryTagsByDigest.ContainsKey(digestData.Digest));
digestDataList.AddRange(eolDigests);
}

It associates those dates with the Dockerfiles having the same .NET version. This is fine for the core repos like runtime, aspnet, and sdk because the images in those repos follow the same versioning as the main .NET product. But in cases like YARP which have their own separate versioning, it's not applicable. There is danger of those versions matching an EOL .NET version and having those images incorrectly annotated as EOL when they're not.

So there's a need to be able to scope the product EOL date to specific repos so that it won't match on other repos where those dates aren't applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant