-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove logging #245
Comments
@AndreyAkinshin @mattwarren What do you guys think about adding this feature? I think that I can add StreamLogger to DefaultConfig and get it done quite easily. The question is if we should allow this to happen? |
@viktor-morin why closed? by accident I assume? |
For me that works mostly in cloud (Azure) and dont want to save files locally on the VM, and also be able to run several benchmarks simultaneously, I think this is a good feature. Should be quite easy to implement. From my view I cant see any drawbacks :) |
Sorry, my misstake :) |
I would also like to introduce the possibility to have a random name on the executable file: |
You can set |
This method throws an exception if I run two at the same time, so my comment is still valid: It refer to BDN.AUTO |
It's a good idea to have the
So, why do you need this feature? What the your goal? A few additional comments:
|
The reason I want to run several benchmarks simultaneosuly was in a way to have concurrent benchmarks, as I see you are working on. I'm using Service Fabric and the Actor design pattern. At the moment I'm testing different WebAPI and looking at the response time (benchmarking this). I want to be able to call a WebAPI as I do right now severals times, but also simultaneously. I'm doing that today as a seperate Actor which is a singelton (one thread) to try to simulate each Actor as a "client" calling these WebAPI. If I run this simultaneously are BenchmarkDotNet affecting eachother? |
Yes, of course, you will not get any meaningful measurements. I know that concurrent benchmarks is a nice feature to have, a lot of people want it. But it's also a tricky feature, it's easy to make a lot of mistakes here. |
I mean, of course it will affect the measurements. But each code should be run with it own resources and in a singelton where it dosn't know about eachother. It that case shouldnt we be able to measure the concurrency of the backend and how fast the WebAPI is when several clients are asking for data simultaneously? |
Ok, I get it. Anyway, you can't use BenchmarkDotNet for such experiments right now, sorry. We have a lot of different stages per each benchmarks (like pilot, warmup, etc.), we have several launches per each benchmark, and so on. This workflow will not work in you case because now there is no any way to synchronize these stages. Even stupid handwritten Stopwatch-based benchmark will be better for your case than several BenchmarkDotNet session at the same time. |
Okay, thanks for the input! |
Make it possible to not logg to HDD (drive).
I'm using benchmark inside Service Fabric (Azure) and it would be great to disable logging to file.
In the meanwhile have I changed logger.Writeline to logger?.Writeline which almost gives the solution.
The text was updated successfully, but these errors were encountered: