From 0868dafe403407561f86de3390f87876c81fe2e2 Mon Sep 17 00:00:00 2001 From: Adam Sitnik Date: Tue, 22 Mar 2022 20:53:53 +0100 Subject: [PATCH] disable AwaitingTasksShouldNotInterfereAllocationResults for InProcess toolchain as it's flaky, contributes to #1925 (#1961) --- .../BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs b/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs index 89af9fd4c9..3c01dffb1e 100755 --- a/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs +++ b/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs @@ -147,6 +147,11 @@ public class NonAllocatingAsynchronousBenchmarks [Trait(Constants.Category, Constants.BackwardCompatibilityCategory)] public void AwaitingTasksShouldNotInterfereAllocationResults(IToolchain toolchain) { + if (toolchain.IsInProcess) + { + return; // it's flaky: https://github.com/dotnet/BenchmarkDotNet/issues/1925 + } + AssertAllocations(toolchain, typeof(NonAllocatingAsynchronousBenchmarks), new Dictionary { { nameof(NonAllocatingAsynchronousBenchmarks.CompletedTask), 0 },