feat: make app_id a public API #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #128 I decided to push two commits to this PR, since the seconds depends on the first. |
|
Hello @maartenbreddels I will be looking into this. |
|
Hi, Happy to add them! Regards, Maarten |
ddl-olsonJD
suggested changes
Jul 27, 2022
| self.log.debug(f"App {app_id} status={status}") | ||
| if status and status != "Stopped" and status != "Failed": | ||
| url = self._routes.app_stop(app_id) | ||
| response = self.request_manager.post(url) | ||
| return response | ||
|
|
||
| def __app_get_status(self, id) -> Optional[str]: | ||
| app_id = self._app_id | ||
| def app_id(self): |
There was a problem hiding this comment.
Set as a property as well.
| # for backwards compatibility, we keep this property | ||
| return self.app_id() | ||
|
|
||
| def app_get_status(self, id) -> Optional[str]: |
There was a problem hiding this comment.
def def app_get_status(self, ext_app_id=None) -> Optional[str]:
app_id = ext_app_id if ext_app_id else self.app_id
| if app_id is None: | ||
| return None | ||
| url = self._routes.app_get(app_id) | ||
| response = self.request_manager.get(url).json() | ||
| return response.get("status", None) | ||
|
|
||
| def __app_get_status(self, id) -> Optional[str]: | ||
| # for backwards compatibility, we keep this method | ||
| return self.__app_get_status() |
There was a problem hiding this comment.
meant to call app_get_status?
|
close as out of date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127