Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for type parameters #393

Open
dominikh opened this issue Dec 14, 2021 · 4 comments
Open

Add support for type parameters #393

dominikh opened this issue Dec 14, 2021 · 4 comments

Comments

@dominikh
Copy link
Owner

No description provided.

@muirdm
Copy link
Collaborator

muirdm commented Mar 26, 2022

I was looking at this, at least in terms of font locking. For ambiguous cases like foo[bar](baz) do you think we should assume it is a generic function instantiation and treat "bar" as a type, or leave it as-is?

@dominikh
Copy link
Owner Author

I say we leave it as is.

@muirdm
Copy link
Collaborator

muirdm commented Mar 26, 2022

Beyond #400, the only other thing I'm aware of for fontification is fontifying function calls and composite literal type names properly in foo[int](123) and some.Struct[int]{foo: bar}. Anything else?

@dominikh
Copy link
Owner Author

I'm the wrong person to ask about fontification, I barely use any. But I'd like to err on the side of "no fontification" over "wrong fontification". So since we lack type info, we can't do anything for foo[int](123).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants