Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information about sozo arguments priorities #176

Closed
glihm opened this issue Jan 10, 2024 · 4 comments
Closed

Add information about sozo arguments priorities #176

glihm opened this issue Jan 10, 2024 · 4 comments
Assignees
@RolandoDrRobot
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Milestone
0.6.0

Comments

@glihm
Copy link
Contributor

glihm commented Jan 10, 2024

Sozo is being reworked to have these priorities:

  1. CLI arguments always takes precedence.
  2. Then the environment variables.
  3. Finally, anything found inside the scarb manifest.

We may add a section on that on the book once this PR is merged dojoengine/dojo#1405 to bring better understanding for the user to the possibilities around configurations.
@ponderingdemocritus ponderingdemocritus added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Jan 23, 2024
@ponderingdemocritus ponderingdemocritus added this to the 1.0.0 milestone Feb 27, 2024
@RolandoDrRobot
Copy link
Contributor

@ponderingdemocritus @glihm Hello 👋 I would like to take care of this, could you assign It to me? thanks!

@glihm
Copy link
Contributor Author

glihm commented Apr 29, 2024

@ponderingdemocritus @glihm Hello 👋 I would like to take care of this, could you assign It to me? thanks!

If you have any question please let's know, and don't hesitate to test that sozo behaves as the documentation stipulates. 👍

@RolandoDrRobot
Copy link
Contributor

@glihm This one is still in progress, been reading Dojo Book and what sozo is, gonna start the actual PR tomorrow, thanks

@RolandoDrRobot
Copy link
Contributor

Hello #269 @glihm could you check If this is going on good path? thanks!
Here you can reach me If wanna dm me:

  • Discord: roloxworld
  • Telegram: roloxworld

@RolandoDrRobot RolandoDrRobot mentioned this issue May 13, 2024
Merged
lambda-0x added a commit that referenced this issue Jun 2, 2024
@RolandoDrRobot @lambda-0x
Add information about sozo arguments priorities #176 (#269)
2a42fda 
* [book-176] Add information about sozo arguments priorities

* [book-176] Code review feedback

* [book-176] More code review feedback

* [book-176] More code review feedback

* [book-176] Update keystore command

* clean up

---------

Co-authored-by: lambda-0x <[email protected]>
@github-project-automation github-project-automation bot moved this to Done in Dojo Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RolandoDrRobot RolandoDrRobot

Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
No open projects
Dojo
Status: Done
Milestone
0.6.0
Development

No branches or pull requests
3 participants
@glihm @RolandoDrRobot @ponderingdemocritus