Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 crash if using flexMatrix #31

Open
daverodgman opened this issue Jan 3, 2012 · 0 comments
Open

IE8 crash if using flexMatrix #31

daverodgman opened this issue Jan 3, 2012 · 0 comments

Comments

@daverodgman
Copy link

Using IE8 / flexie 1.0.3 / jquery 1.7.1 / selectivizr v1.0.2:

        var flexie = new Flexie.box({
            target: newElement[0],
            flexMatrix: this.options.use_flexie ? [0, 1, 0] : [0, 1],
        });

crashes at line 1551 because x.properties is null. Removing the flexMatrix argument fixes the crash.

The following seems to fix it. It does leave an overflow problem (the right hand column ends up on a new line when it should fill the current row), which might or might not be related to this fix:

--- a/Software/CurryWebContent/content/js/flexie.js
+++ b/Software/CurryWebContent/content/js/flexie.js
@@ -1547,6 +1547,7 @@ var Flexie = (function (win, doc) {
for (k = 0, l = flexers[key].length; k < l; k++) {
x = flexers[key][k];
max = NULL;

  •                                                   if (x.properties != null) {
                                                    for (m = 0, n = x.properties.length; m < n; m++) {
                                                            rule = x.properties[m];
    

@@ -1554,6 +1555,7 @@ var Flexie = (function (win, doc) {
max = parseFloat(rule.value);
}
}

  •                                                   }
                                                    if (!max || x.match[self.props.out] > max) {
                                                            appendPixelValue(x.match, self.props.pos, NULL);
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant