New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate compiler warnings & support non-real values for onnxFmu.cpp/.hpp #49

Open

2 tasks

StephanieKemna opened this issue Jul 22, 2024 · 0 comments

Labels

Collaborator

StephanieKemna commented Jul 22, 2024 •

edited

Loading

Changes need for onnxFmu.cpp and onnxFmu.hpp:

There is an implicit conversion for onnxInputs from FMIReal to float, e.g. onnxFmu.cpp line 88 or line 108. The current arrays (e.g. onnxInputs_, onnxOutputs_, onnxStates_) are for float values instead of FMIReal. There are also comments in onnxFmu.cpp that it should be changed to handle non-real values.
Nameless structs in onnxFmu.hpp create warnings.

Example warning:

..\src\mlfmu\fmu_build\templates\onnx_fmu\onnxFmu.cpp(88,38): warning C4244: '=': conversion from 'cppfmu::FMIReal' to '_Ty', possible loss of data

StephanieKemna added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment