Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generated FMU source code easier to modify? #41

Open
KristofferSkare opened this issue Jun 26, 2024 · 0 comments
Open

Make generated FMU source code easier to modify? #41

KristofferSkare opened this issue Jun 26, 2024 · 0 comments
Labels
question Further information is requested

Comments

@KristofferSkare
Copy link
Collaborator

KristofferSkare commented Jun 26, 2024

The process of building the ML-FMU can be split into two parts to enable editing of the source code using the commands codegen and compile instead of build. There is maybe a question of if this is really a necessary feature to have. But if we are keeping the feature I think it should be improved.

However, actually doing some useful modifications of the source code is quite difficult. This is because of two main reasons.

  • Lacking documentation of the OnnxFmu class that the generated inherits from
  • All member variables of OnnxFmu are private making access to them difficult or impossible in some cases.

In addition it might be hard for users to even know how or why one would do this. I (@KristofferSkare ) can think of some cases where it is useful.

@KristofferSkare KristofferSkare added the question Further information is requested label Jun 26, 2024
@KristofferSkare KristofferSkare changed the title Make generated FMU source code easier to modify Make generated FMU source code easier to modify? Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant