Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to depend on astropy-base in conda-forge recipe #1078

Open
mschwamb opened this issue Dec 7, 2024 · 2 comments
Open

need to depend on astropy-base in conda-forge recipe #1078

mschwamb opened this issue Dec 7, 2024 · 2 comments
Assignees
Labels
version 1.0 tasks that need to be completed before the first software release

Comments

@mschwamb
Copy link
Collaborator

mschwamb commented Dec 7, 2024

conda-forge automated message says:

I noticed that this recipe depends on astropy instead of astropy-base. The astropy feedstock has been split into two packages, astropy-base only has required dependencies and astropy now has all optional dependencies. To maintain the old behavior you should migrate to astropy-base. Thus I made this PR.

Notes and instructions for merging this PR:

Make sure that the recipe can indeed only depend on astropy-base.
Please merge the PR only after the tests have passed.
Feel free to push to the bot's branch to update this PR if needed.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12213013335 - please use this URL for debugging.
You can view, comment on, or merge this pull request online at:

conda-forge/sorcha-addons-feedstock#2
Commit Summary

https://github.com/conda-forge/sorcha-addons-feedstock/pull/2/commits/dacff63326f01819ea5b34b8d01f43b4819b1f88 use astropy-base instead of astropy
https://github.com/conda-forge/sorcha-addons-feedstock/pull/2/commits/67340c12d54036453adc4178ebab10eab5456520 MNT: Re-rendered with conda-build 24.11.2, conda-smithy 3.44.9, and conda-forge-pinning 2024.12.07.12.40.44

File Changes

(7 files)

M [.azure-pipelines/azure-pipelines-linux.yml](https://github.com/conda-forge/sorcha-addons-feedstock/pull/2/files#diff-db71f153817776d1878eba60d2c71512969cca05e702cdc382ac178b6fb316df) (2)
M [.ci_support/linux_64_.yaml](https://github.com/conda-forge/sorcha-addons-feedstock/pull/2/files#diff-999d2f034982a9a29cc0f5a5340497f76ff9243576ea74e5954ec5ad5f32b74c) (4)
M [.gitattributes](https://github.com/conda-forge/sorcha-addons-feedstock/pull/2/files#diff-618cd5b83d62060ba3d027e314a21ceaf75d36067ff820db126642944145393e) (4)
M [.scripts/build_steps.sh](https://github.com/conda-forge/sorcha-addons-feedstock/pull/2/files#diff-22c5a202c93f351348030b671d6e0e1fdae11f4a23eeff71551c4ef90d88bddb) (18)
M [azure-pipelines.yml](https://github.com/conda-forge/sorcha-addons-feedstock/pull/2/files#diff-7915b9b726a397ae7ba6af7b9703633d21c031ebf21682f3ee7e6a4ec52837a5) (29)
M [build-locally.py](https://github.com/conda-forge/sorcha-addons-feedstock/pull/2/files#diff-1b42e01241a76f3b6395e3f38132d4df441c48bb13d20cc5a35bfc71a8aa3340) (16)
M [recipe/meta.yaml](https://github.com/conda-forge/sorcha-addons-feedstock/pull/2/files#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9a) (4)

Patch Links:

https://github.com/conda-forge/sorcha-addons-feedstock/pull/2.patch
https://github.com/conda-forge/sorcha-addons-feedstock/pull/2.diff

@mschwamb mschwamb added the version 1.0 tasks that need to be completed before the first software release label Dec 22, 2024
@mschwamb
Copy link
Collaborator Author

mschwamb commented Jan 14, 2025

Also this

Hi! This is the friendly automated conda-forge-linting service (see below). Looks like it made a PR conda-forge/sorcha-feedstock#17

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

ℹ️ noarch: python recipes should usually follow the syntax in our [documentation](https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python) for specifying the Python version.
    For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12161285882. Examine the logs at this URL for more detail.

@mschwamb
Copy link
Collaborator Author

regro-cf-autotick-bot requested your review on: conda-forge/sorcha-addons-feedstock#2 Suggestion: depend on astropy-base instead of astropy as a code owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version 1.0 tasks that need to be completed before the first software release
Projects
None yet
Development

No branches or pull requests

2 participants