New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: macro redefined #42

Open

vtorri opened this issue Nov 2, 2023 · 0 comments

vtorri commented Nov 2, 2023

ewarnings:

../src/bin/ui/shortcuts/shortcuts.h:49: warning: "MOD_SHIFT" redefined
49 | #define MOD_SHIFT (1 << 0)
../src/bin/ui/shortcuts/shortcuts.h:51: warning: "MOD_ALT" redefined
51 | #define MOD_ALT (1 << 2)

see:

https://learn.microsoft.com/en-us/windows/win32/inputdev/wm-hotkey

I think that :

these macro should be an enum
they should a prefix, like EFLT or osmething like that

Vincent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment