Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release workflow being triggered each time a pull request is merged to main #359

Closed
achou11 opened this issue Oct 26, 2023 · 1 comment · Fixed by #379
Closed

Release workflow being triggered each time a pull request is merged to main #359

achou11 opened this issue Oct 26, 2023 · 1 comment · Fixed by #379

Comments

@achou11
Copy link
Member

achou11 commented Oct 26, 2023

Description

Seems like the workflow is erroneously being scheduled when we merge non-release PRs into main

examples:

Not exactly sure how to fix but wanted to document since I keep getting emails about failed jobs 😄
@achou11
Copy link
Member Author

achou11 commented Nov 15, 2023

Turns out the issue is that our configuration is attempting to run a npm script that doesn't exist (build). PR to fix is here: #379

@achou11 achou11 mentioned this issue Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix release workflow configuration digidem/comapeo-core
1 participant
@achou11