Add dataType.createWithDocId() method
#190
Assignees
Comments
This was referenced Aug 18, 2023
Closed
4 tasks
gmaclennan
added a commit
that referenced
this issue
Aug 18, 2023
Fixes Add `dataType.createWithDocId()` method #190
2 tasks
gmaclennan
added a commit
that referenced
this issue
Aug 18, 2023
* feat: Add internal `dataType.createWithDocId()` Fixes Add `dataType.createWithDocId()` method #190 * Add type def for createWithDocId * Add tests * fix typing in unit test
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The implementation of roles and core ownership and projectInfo / projectSettings requires that
docIdhas a specific value, rather than being random.We don't want this method to be exposed to any public API (e.g. when we expose datatype instances to the public API), since this should only be used internally.
Implementation
Use a non-shared unique symbol to name the method e.g.
const kCreateWithDocId = new Symbol('kCreateWithDocId')and export this locally, but do not include in the public exports of@mapeo/core. Then we can use this bydataType[kCreateWithDocId](docId, value). This is how fastify does it.Tasks
The text was updated successfully, but these errors were encountered: