Resource leak for maven plugin used with java eclipse formatter

[pzygielo]

Resource leak for maven plugin used with java eclipse formatter

---

After check goal of spotless maven plugin (1.24.1) configured to use java > eclipse, temporary directory is left in filesystem.

Seems that below deleteOnExit

spotless/_ext/eclipse-base/src/main/java/com/diffplug/spotless/extra/eclipse/base/service/TemporaryLocation.java

Lines 43 to 50 in 6c7db83

	private static URL createTemporaryDirectory() {
	try {
	Path locationPath = Files.createTempDirectory(TEMP_PREFIX);
	locationPath.toFile().deleteOnExit();
	return locationPath.toUri().toURL();
	} catch (IOException e) {
	throw new IOError(e);
	}

is not enough, as directory is non-empty (contains subdirectory org.eclipse.core.runtime), and as such is not deleted on JVM exit.

[fvgh]

@pzygielo
Thank's for the report.
I noticed the problem just recently while implementing #292. I am sure that for the initial versions of the Eclipse formatters the directory was always empty. That's why I never provided a better implementation. Now it seems to be used for file locks. Anyhow, for #292 I need some temporary files and maybe an extension of the implementation. But I also would like to have a look why the .manager\.fileTableLock is created in the first place. It is possible that I can improve some things in the setup of the Eclipse framework.

[pzygielo]

@fvgh - now that you brought hidden files to light (I missed them) - in top temporary dir com_diffplug_spotless_extra_eclipse#... there is also non-empty-with-files .metadata (but I'm sure you already know, or would know on the course of developing change).

[nedtwigg]

Fixed in 3.24.3

[pzygielo]

Fixed in 3.24.3

As I am maven-ing, I upgraded plugin to 1.24.3 (both tags happily refer to the same 0d08d58 😄 anyway), and I confirm - no temporary files left after goal run.
Thank you.