Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new "release" of ningen, so gtkcord3 can build #4

Closed
Titaniumtown opened this issue Aug 26, 2020 · 3 comments
Closed

Create new "release" of ningen, so gtkcord3 can build #4

Titaniumtown opened this issue Aug 26, 2020 · 3 comments

Comments

@Titaniumtown
Copy link

I made a PR (diamondburned/gtkcord3/pull/94) on gtkcord3 (you can read more about it there) but gtkcord3 fails to build because a new release of ningen hasn't been created, so the folder "handlerrepo" isn't found, and the build fails. Hope this issue can be resolved!

@Titaniumtown
Copy link
Author

Nevermind, this can be fixed on gtkcord3's side.

@PaulDGillis
Copy link

PaulDGillis commented Sep 16, 2020

@diamondburned Would it be possible to get an updated release? While gtkcord3 lists ningen as v0.1.1-{something or other} it always falls back to 0.1.0 for me. I think this also may be why the latest commit on gtkcord3 master failed its build check.

Currently I have a local copy of arikawa and ningen that I'm developing with where I've fixed the compilation. I've also updated arikawa to 1.3.2 in my local copy of gtkcord3 and plan to submit a pr. I just wanted to ask if we could get an updated ningen to go along with the update to arikawa 1.3 for the pr.

Arikawa has had about 20 releases since gtkcord3(AK v0.9.6) last updated it, and about 21 since ningen v0.1.0(AK v0.9.5). The pr would keep gtkcord from falling too far behind, since I was hoping to implement status in gtkcord after fixing an issue I created on arikawa.

@diamondburned
Copy link
Owner

@Pauldg7 I have made a v0.2.0 for ningen, which uses the latest Arikawa release (v1.3.2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants