Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move command line stuff to separate package and avoid fsnotify dependency? #370

Open
georgefst opened this issue Nov 26, 2024 · 1 comment
Assignees

Comments

@georgefst
Copy link

Personally, while I think Diagrams.Backend.CmdLine is cool, in six and a half years of using this library quite regularly, I only ever used it on day one. I prefer to just call ghcid or ghciwatch for this sort of thing, not least because code caring about its own source location seems brittle. So it's always felt like something which belongs in a separate library.

This has become a concrete issue for me when targeting Wasm, since fsnotify doesn't build there. This is the only module which relies on fsnotify.

Obviously this would be a breaking change, but it'd have a one-line fix. And I wouldn't imagine this module is seeing serious production use.

@byorgey
Copy link
Member

byorgey commented Nov 26, 2024

Oh, good suggestion. I'm all for getting diagrams to build with Wasm.

I will look into some options. Perhaps one less-impactful change we could make that would still achieve the goal would be to keep Diagrams.Backend.CmdLine but simply remove the looped rebuilding feature (and hence the fsnotify dep). With stuff like ghciwatch, ghcid, entr, etc. it's not too hard to set it up externally. I'd rather not more/remove Diagrams.Backend.CmdLine entirely since there's a lot of stuff in there besides the looped rebuilding and I think it would break a lot of workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants