Load TypeScript in ESM mode if package.json type is module #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrist
changed the title
|
@henrist Thank you for the PR! Can you create new test for this? |
|
@DorianMazur Test added (and added a missing inclusion of the commonjs variant). Making the test fail before my fixes requires a bit of code. For context this is the error: Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in /Users/henrste/repo/node_modules/dependency/package.json
at exportsNotFound (node:internal/modules/esm/resolve:314:10)
at packageExportsResolve (node:internal/modules/esm/resolve:605:13)
at resolveExports (node:internal/modules/cjs/loader:638:36)
at Function._findPath (node:internal/modules/cjs/loader:743:31)
at node:internal/modules/cjs/loader:1230:27
at nextResolveSimple (/Users/henrste/repo/node_modules/.pnpm/tsx@4.19.2/node_modules/tsx/dist/register-DCnOAxY2.cjs:3:942)
at /Users/henrste/repo/node_modules/.pnpm/tsx@4.19.2/node_modules/tsx/dist/register-DCnOAxY2.cjs:2:2550
at /Users/henrste/repo/node_modules/.pnpm/tsx@4.19.2/node_modules/tsx/dist/register-DCnOAxY2.cjs:2:1624
at resolveTsPaths (/Users/henrste/repo/node_modules/.pnpm/tsx@4.19.2/node_modules/tsx/dist/register-DCnOAxY2.cjs:3:760)
at Function._resolveFilename (/Users/henrste/repo/node_modules/.pnpm/tsx@4.19.2/node_modules/tsx/dist/register-DCnOAxY2.cjs:3:1038)When a package declares conditional exports using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1848
Motivation and Context
See #1848
How Has This Been Tested?
Tested on a service locally that failed previously. See #1848 for environment details.
Screenshots (if appropriate):
N/A