Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 22.12 causes error _serverlessExternalPluginName on servereless before v3.40 #1844

Open
eusousu opened this issue Dec 18, 2024 · 3 comments

Comments

@eusousu
Copy link

eusousu commented Dec 18, 2024

Bug Report

The error is the same as stated here serverless/serverless#12936 as the version target as dependency for the serverless-offline v13 is serverless ^3.2 the fixing update is not enforced.

Being nodejs22.x a supported runtime maybe the version should be changed to fix this here also.

Current Behavior

Using Node v22.12 or later causes _serverlessExternalPluginName error

Expected behavior

Node v22.X should be supported

Environment

  • serverless version: v3.39.0
  • serverless-offline version: v13.9.0
  • node.js version: v22.12
  • OS: windows 11

Possible Solution

Change the dependency to serverless 3.40

@henrist
Copy link
Contributor

henrist commented Jan 14, 2025

Bumping the minimum version of serverless forces users over to the newer version, which isn't necessary what you want. The updated serverless version is within the allowed range, so you just need to update the serverless version you have installed. No change here is required.

@eusousu
Copy link
Author

eusousu commented Jan 14, 2025

No change here is required.

Being node v22 a supported runtime for serverless-offline v13 then I understand that it should be usable on this runtime as is. The current state does so it fails to do anything on the supported node v22 with no indication to the user to which is the best approach for solving the issue.

@henrist
Copy link
Contributor

henrist commented Jan 14, 2025

Let's see it differently: For every bug fix of serverless there will not be a new release of serverless-offline to bring that in, or any other that declares it as peer dependency likewise.

The problem is beyond this repo, and how dependency management in Node.js works in general: Simply update the serverless version you have to a newer version. It is outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants