Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub URL from context #204

Open
lure8225 opened this issue Dec 6, 2023 · 2 comments
Open

GitHub URL from context #204

lure8225 opened this issue Dec 6, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@lure8225
Copy link

lure8225 commented Dec 6, 2023

Hi, for using this in a GitHub enterprise context it would be necessary to get the base url from the context instead of hardcoding it to github.com

urlToConfig = `https://github.com/${srcInfo.owner}/${srcInfo.repo}/blob/main/${basePathTrimmed}/${f}/${metadataFile}`;

I think it should be available from here

https://github.com/actions/toolkit/blob/04945c6048e796f86b5c4cf1965faa378af67480/packages/github/src/context.ts#L23C5-L23C5

Sorry that I currently am not able to directly do a PR for that.

@joshspicer joshspicer added the enhancement New feature or request label Dec 6, 2023
@joshspicer
Copy link
Member

This generated URL is pointing to documentation for a dev container Feature, which themselves are hosted in container registries. I want to understand the goal here better - is your team publishing Features to a container registry with the source code in your private GitHub enterprise instance?

cc/ @eljog

@lure8225
Copy link
Author

lure8225 commented Dec 7, 2023

Exactly, we are publishing features to a private OCI registry from a GHE instance. These features are then used for building images/devcontainers which our internal workspaces are using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants