Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all icons are being displayed correctly #115

Closed
valsamis-d opened this issue Jul 31, 2023 · 3 comments
Closed

Not all icons are being displayed correctly #115

valsamis-d opened this issue Jul 31, 2023 · 3 comments

Comments

@valsamis-d
Copy link

valsamis-d commented Jul 31, 2023

Expected Behavior

I'm expecting to see icons for all files. I don't have any special files. Just very commons ones.

Current Behavior

When I'm doing a dir in Powershell 7 icons are not being displayed correctly for all file types. See screenshots below:

image

image

Steps to Reproduce (for bugs)

  1. Install Terminal-Icons
  2. Install NF Fonts (both CaskyadiaCove NF and LiberationMono NF.
  3. Import Terminal-Icons (tried with both module name and absolute path to Terminal-Icons.psm1)
  4. dir command

Context

Nothing critical here. It's just ugly to see some files types having this nice icon and other not :)

Your Environment

  • Operating System: Windows 11 Enterprise 22H2
  • PowerShell version: 7.3.6
  • Windows Terminal: tried with both regular version 1.17.11461.0 and preview version 1.18.1462.0
  • Module version used: 0.11.0

I also tried type PowerShell\Modules\Terminal-Icons\0.11.0\Data\glyphs.ps1 and indeed some icons are not being rendered correctly (see question marks):

image

Any ideas?

EDIT:

I read through #99 and #89 but workarounds and advices offered there did not help :(

Thank you
Dimitrios

@valsamis-d
Copy link
Author

Never mind guys. I figured it out. I was using v2 of NerdFonts. After downloading v3 eveything is working just fine and... is very sexy :)

@tusan-tsvetkoff
Copy link

I am experiencing the same issue. Same icons are not being recognized. Even though I have downloaded the latest nerd font patched fonts of JetBrains Mono and CascaydiaCove, downloaded from here

Small example inside the Terminal-Icons directory
image

I also did what @valsamis-d suggested and ran type glyphs.ps1
image
A small part of the glyphs that are not recognized. The ones nf-fae-x, nf-fa-x, nf-code-x, seem to be working, though there's an issue with the nf-md-x icons.

I have also ran oh-my-posh config migrate glyphs --write, which fixed a few of the icons and glyphs, though (as we can see) not all.

Environment

  • OS Windows 10 Pro 22H2
  • PowerShell 7.3.6
  • Terminal-Icons module 0.11.0

Apologies for hijacking this already closed issue. If I must, I'll open a separate one.

@valsamis-d
Copy link
Author

@Tusankata have you installed Nerd Fonts v3.0.2 for the "current user" or "all users"? I'd suggest installing them for "all users"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants